-
Notifications
You must be signed in to change notification settings - Fork 1.1k
docs(tools/alloydbainl): only require psv installation when needed #2283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @Yuan325, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines the documentation for the AlloyDB AI NL tool, specifically addressing the installation requirements for the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request aims to clarify that the parameterized_views extension is only necessary when using the Parameterized Secure Views (PSV) feature with the alloydb-ai-nl tool. While the intention is good, the change introduces an inconsistency within the documentation, as the tool's reference table marks nlConfigParameters (which are for PSVs) as a required field. I have added a comment to address this contradiction to ensure the documentation is clear and accurate for users.
|
🧨 Preview deployments removed. |
…eeded (#2283) Update existing docs to install PSV extensions **only** when needed. This tool could be use without installing PSV if NLConfigParam is not used. --------- Co-authored-by: Averi Kitsch <[email protected]> 647b04d
…eeded (googleapis#2283) Update existing docs to install PSV extensions **only** when needed. This tool could be use without installing PSV if NLConfigParam is not used. --------- Co-authored-by: Averi Kitsch <[email protected]> 647b04d
…eeded (googleapis#2283) Update existing docs to install PSV extensions **only** when needed. This tool could be use without installing PSV if NLConfigParam is not used. --------- Co-authored-by: Averi Kitsch <[email protected]> 647b04d
…eeded (googleapis#2283) Update existing docs to install PSV extensions **only** when needed. This tool could be use without installing PSV if NLConfigParam is not used. --------- Co-authored-by: Averi Kitsch <[email protected]> 647b04d
…eeded (googleapis#2283) Update existing docs to install PSV extensions **only** when needed. This tool could be use without installing PSV if NLConfigParam is not used. --------- Co-authored-by: Averi Kitsch <[email protected]> 647b04d
…eeded (googleapis#2283) Update existing docs to install PSV extensions **only** when needed. This tool could be use without installing PSV if NLConfigParam is not used. --------- Co-authored-by: Averi Kitsch <[email protected]> 647b04d
…eeded (googleapis#2283) Update existing docs to install PSV extensions **only** when needed. This tool could be use without installing PSV if NLConfigParam is not used. --------- Co-authored-by: Averi Kitsch <[email protected]> 647b04d
…oogleapis#2283) Update existing docs to install PSV extensions **only** when needed. This tool could be use without installing PSV if NLConfigParam is not used. --------- Co-authored-by: Averi Kitsch <[email protected]>
Update existing docs to install PSV extensions only when needed. This tool could be use without installing PSV if NLConfigParam is not used.