Skip to content

ci(bigtable): more adjustments to handle internal Cord usage #15569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 25, 2025
+20 −2
Merged

ci(bigtable): more adjustments to handle internal Cord usage #15569

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion google/cloud/bigtable/value.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ std::ostream& StreamHelper(std::ostream& os, // NOLINT(misc-no-recursion)
return os << v.string_value();
case StreamMode::kAggregate:
os << '"';
EscapeQuotes(os, v.string_value());
EscapeQuotes(os, AsString(v.string_value()));
return os << '"';
}
return os; // Unreachable, but quiets warning.
Expand Down
20 changes: 19 additions & 1 deletion google/cloud/bigtable/value_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,11 +240,29 @@ template <typename T,
.string_value()),
typename std::enable_if<
std::is_same<std::remove_cv_t<std::remove_reference_t<U>>,
absl::Cord>::value>::type* = nullptr>
absl::Cord>::value>::type* = nullptr,
typename std::enable_if_t<
!std::is_same<T, std::vector<std::string>>::value, int> = 0>
StatusOr<T> MovedFromString(Value const&) {
return T{""};
}

template <typename T,
typename U = decltype(std::declval<google::bigtable::v2::Value>()
.string_value()),
typename std::enable_if<
std::is_same<std::remove_cv_t<std::remove_reference_t<U>>,
absl::Cord>::value>::type* = nullptr,
typename std::enable_if_t<
std::is_same<T, std::vector<std::string>>::value, int> = 0>
StatusOr<T> MovedFromString(Value const& v) {
auto v2 = v.get<T>();
if (!v2.ok()) {
return v2.status();
}
return T{v2->size(), std::string{""}};
}

// NOTE: This test relies on unspecified behavior about the moved-from state
// of std::string. Specifically, this test relies on the fact that "large"
// strings, when moved-from, end up empty. And we use this fact to verify that
Expand Down