Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for field generate_omitted_as_internal in selective gapic generation #13482

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

gcf-owl-bot[bot]
Copy link
Contributor

@gcf-owl-bot gcf-owl-bot bot commented Jan 30, 2025

  • Regenerate this pull request now.

PiperOrigin-RevId: 721375937

Source-Link: googleapis/googleapis@78733bf

Source-Link: https://github.com/googleapis/googleapis-gen/commit/a1335fa94639979a3831e06035aac44a24fdacc4
Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlYXBpcy1jb21tb24tcHJvdG9zLy5Pd2xCb3QueWFtbCIsImgiOiJhMTMzNWZhOTQ2Mzk5NzlhMzgzMWUwNjAzNWFhYzQ0YTI0ZmRhY2M0In0=

@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jan 30, 2025
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 30, 2025
@gcf-owl-bot gcf-owl-bot bot marked this pull request as ready for review January 30, 2025 18:16
@gcf-owl-bot gcf-owl-bot bot requested a review from a team as a code owner January 30, 2025 18:16
@trusted-contributions-gcf trusted-contributions-gcf bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 30, 2025
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 30, 2025
@vchudnov-g vchudnov-g added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 30, 2025
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 30, 2025
@trusted-contributions-gcf trusted-contributions-gcf bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 30, 2025
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 30, 2025
Copy link
Contributor Author

gcf-owl-bot bot commented Jan 30, 2025

Owl bot is regenerating pull request 13482...
Build name: ODcwYmM0NzYtMzExMy00NDUzLThjYTEtNGEzZGUwNzE0MTkx

… gapic generation

PiperOrigin-RevId: 721375937

Source-Link: googleapis/googleapis@78733bf

Source-Link: googleapis/googleapis-gen@a1335fa
Copy-Tag: eyJwIjoicGFja2FnZXMvZ29vZ2xlYXBpcy1jb21tb24tcHJvdG9zLy5Pd2xCb3QueWFtbCIsImgiOiJhMTMzNWZhOTQ2Mzk5NzlhMzgzMWUwNjAzNWFhYzQ0YTI0ZmRhY2M0In0=
@gcf-owl-bot gcf-owl-bot bot force-pushed the owl-bot-copy-packages-googleapis-common-protos branch from 21e0b53 to 3121cc1 Compare January 30, 2025 22:42
@trusted-contributions-gcf trusted-contributions-gcf bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 30, 2025
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 30, 2025
@trusted-contributions-gcf trusted-contributions-gcf bot added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 30, 2025
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 30, 2025
@vchudnov-g vchudnov-g added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jan 30, 2025
@vchudnov-g
Copy link
Contributor

The *_pb2.py files all seem to have their license header elided. I want to understand that before we merge, since IIUC there are legal requirements to include that header.

@parthea Any insights?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not merge Indicates a pull request not ready for merge, due to either quality or timing. kokoro:force-run Add this label to force Kokoro to re-run the tests. owl-bot-copy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant