feat(dbapi): wire timeout parameter through Connection to execute_sql - #18484
Open
sakthivelmanii wants to merge 1 commit into
Open
sakthivelmanii wants to merge 1 commit into
sakthivelmanii wants to merge 1 commit into
Conversation
sakthivelmanii
force-pushed
the
feat/dbapi-timeout
branch
from
September 28, 2026 10:57
dc55eed to
e76a368
Compare
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces timeout support for Spanner DB-API operations, allowing users to specify a timeout duration for connections and individual SQL statements. It updates the Connection, Cursor, and batch_dml_executor modules to propagate this timeout value and includes comprehensive unit tests. The reviewer suggests refactoring the _do_batch_update_autocommit function to accept the timeout parameter directly instead of the cursor object to improve decoupling and simplify parameter handling.
- Wire timeout parameter to Connection.__init__, connect(), run_statement(), and validate(). - Pass timeout from connection to execute_sql and batch_update calls when specified. - Add unit tests for DBAPI timeout propagation.
sakthivelmanii
force-pushed
the
feat/dbapi-timeout
branch
from
September 28, 2026 12:40
e76a368 to
aa216ac
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕