Address flaky pubsub system tests #2086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
|
||
| hoover = Hoover() | ||
| retry = RetryInstanceState(hoover.done) | ||
| retry(hoover.suction)() |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| @@ -267,8 +280,9 @@ def test_fetch_delete_subscription_w_deleted_topic(self): | |||
| def _no_topic(instance): | |||
| return instance.topic is None | |||
|
|
|||
| retry = RetryInstanceState(_no_topic, max_tries=6) | |||
| retry(orphaned.reload)() | |||
| # Wait for the topic to clear: up to 63 seconds (2 ** 8 - 1) | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
@dhermes I'm going to merge as is: I disagree that your formulation is clearer, and getting the fix in for the flaky test is way more important that our quibble. |
This was referenced Aug 16, 2016
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Toward #2077, #2079, #2080