Stop using a designated tests project ID. #2288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
dhermes
changed the title
|
LGTM. Lots of pink lines! |
|
Blerg! Not quite enough red lines: lint says we got some unused imports. |
This is because the project ID can be determined directly from the file pointed to by GOOGLE_APPLICATION_CREDENTIALS. Fixes googleapis#2263.
|
OK this broke things big time: Looking into it. |
|
OK I think I know what happened, the key stored in |
dhermes
added a commit
to dhermes/google-cloud-python
that referenced
this pull request
Sep 9, 2016
PR googleapis#2288 broke the Travis build since the key stored (from 2014) didn't have the project ID as a value.
Merged
|
Sent #2292 to fix. |
|
b0rken here as well: Though this is even more b0rken since I deleted the IV and key env. vars. from Travis. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is because the project ID can be determined directly from the file pointed to by
GOOGLE_APPLICATION_CREDENTIALS.Fixes #2263.