Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename traits module to stubs #705

Closed
coryan opened this issue Jan 14, 2025 · 0 comments · Fixed by #891
Closed

Rename traits module to stubs #705

coryan opened this issue Jan 14, 2025 · 0 comments · Fixed by #891
Assignees
@coryan
Labels
next major: breaking change this is a change that we should wait to bundle into the next major version priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@coryan
Copy link
Contributor

coryan commented Jan 14, 2025

I think that name better captures what the module is about: defining the stubs for a service.
@coryan coryan added next major: breaking change this is a change that we should wait to bundle into the next major version priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Jan 14, 2025
@coryan coryan self-assigned this Jan 29, 2025
@coryan coryan changed the title Rename traits module to stub Rename traits module to stubs Jan 29, 2025
@coryan coryan mentioned this issue Jan 29, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@coryan coryan

Labels
next major: breaking change this is a change that we should wait to bundle into the next major version priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cleanup(generator/rust): rename traits module coryan/google-cloud-rust
1 participant
@coryan