Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup(generator/rust): rename traits module #891

Merged

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Jan 29, 2025

Use a name that tells us something about what it does (or provides) vs.
how it is implemented.

Fixes #705

Use a name that tells us something about what it does (or provides) vs.
how it is implemented.
@coryan coryan marked this pull request as ready for review January 29, 2025 14:08
Copy link

codecov bot commented Jan 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.60%. Comparing base (3fa37b5) to head (8cf1d9e).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #891   +/-   ##
=======================================
  Coverage   95.60%   95.60%           
=======================================
  Files          36       36           
  Lines        1364     1364           
=======================================
  Hits         1304     1304           
  Misses         60       60           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coryan coryan merged commit c2edb7c into googleapis:main Jan 29, 2025
15 checks passed
@coryan coryan deleted the cleanup-generator-rust-rename-traits-module branch January 29, 2025 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename traits module to stubs
2 participants