Skip to content

Conversation

PhongChuong
Copy link
Collaborator

@PhongChuong PhongChuong commented Sep 17, 2025

Regenerate bigquery/v2 with pagination and update integration test.

Fixes #1998

Copy link

codecov bot commented Sep 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.21%. Comparing base (4105780) to head (779f4b8).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3351   +/-   ##
=======================================
  Coverage   96.21%   96.21%           
=======================================
  Files         115      115           
  Lines        4574     4574           
=======================================
  Hits         4401     4401           
  Misses        173      173           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@PhongChuong PhongChuong changed the title DO NOT MERGE: preview for generated BigQuery pagination feat(bigquery/v2): generate library with pagination Sep 18, 2025
@PhongChuong PhongChuong marked this pull request as ready for review September 18, 2025 14:29
@PhongChuong PhongChuong requested a review from a team as a code owner September 18, 2025 14:29
@dbolduc
Copy link
Member

dbolduc commented Sep 18, 2025

We need to update the librarian version in the CI for the regenerate builds to pass.

https://github.com/googleapis/google-cloud-rust/blob/main/doc/contributor/howto-guide-generated-code-maintenance.md#making-changes-to-sidekick

@coryan
Copy link
Collaborator

coryan commented Sep 18, 2025

We need to update the librarian version in the CI for the regenerate builds to pass.

https://github.com/googleapis/google-cloud-rust/blob/main/doc/contributor/howto-guide-generated-code-maintenance.md#making-changes-to-sidekick

Blegh, and I just merged my changes, which means it is harder to discover the right version.

@dbolduc
Copy link
Member

dbolduc commented Sep 18, 2025

Blegh, and I just merged my changes, which means it is harder to discover the right version.

@coryan - Send a PR updating librarian to latest and generate all the things.
@PhongChuong - after that goes through, rebase this, and change it to a test(bigquery) PR?

@PhongChuong
Copy link
Collaborator Author

Blegh, and I just merged my changes, which means it is harder to discover the right version.

@coryan - Send a PR updating librarian to latest and generate all the things. @PhongChuong - after that goes through, rebase this, and change it to a test(bigquery) PR?

SGTM.

@coryan
Copy link
Collaborator

coryan commented Sep 18, 2025

Blegh, and I just merged my changes, which means it is harder to discover the right version.

@coryan - Send a PR updating librarian to latest and generate all the things. @PhongChuong - after that goes through, rebase this, and change it to a test(bigquery) PR?

SGTM.

Will do. For the record, the sidekick version with only @PhongChuong 's changes is: v0.1.2-0.20250918140618-f7a7c8e2b04e

@alvarowolfx alvarowolfx self-requested a review September 18, 2025 15:59
Copy link
Collaborator

@alvarowolfx alvarowolfx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can simplify the jobs service test by not worrying on cleaning up jobs (as this can lead to flaky test, as you might try to delete a running job) and also agree with @coryan that this should be renamed as test(bigquery/v2) PR

@PhongChuong PhongChuong changed the title feat(bigquery/v2): generate library with pagination test(bigquery/v2): update integration test with pagination Sep 18, 2025
@coryan
Copy link
Collaborator

coryan commented Sep 18, 2025

I think we can simplify the jobs service test by not worrying on cleaning up jobs (as this can lead to flaky test, as you might try to delete a running job) and also agree with @coryan that this should be renamed as test(bigquery/v2) PR

In some services the list() tests can get really slow if you don't cleanup things.... and you also may hit quota limits. Neither of those concerns may apply to BQ.

@PhongChuong PhongChuong merged commit 51dd919 into googleapis:main Sep 18, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle pagination for non-standard pagination services
4 participants