-
Notifications
You must be signed in to change notification settings - Fork 82
test(bigquery/v2): update integration test with pagination #3351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3351 +/- ##
=======================================
Coverage 96.21% 96.21%
=======================================
Files 115 115
Lines 4574 4574
=======================================
Hits 4401 4401
Misses 173 173 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
We need to update the |
Blegh, and I just merged my changes, which means it is harder to discover the right version. |
@coryan - Send a PR updating librarian to latest and generate all the things. |
SGTM. |
Will do. For the record, the sidekick version with only @PhongChuong 's changes is: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can simplify the jobs service test by not worrying on cleaning up jobs (as this can lead to flaky test, as you might try to delete a running job) and also agree with @coryan that this should be renamed as test(bigquery/v2)
PR
In some services the |
Regenerate bigquery/v2 with pagination and update integration test.
Fixes #1998