Skip to content

Conversation

suzmue
Copy link
Collaborator

@suzmue suzmue commented Sep 19, 2025

Cleanup stale topics created by integration tests. Pubsub topics don't have a create time field, so instead create a label that records the creation time. There are restrictions on the characters used in labels including no uppercase letters. The wkt::Timestamp serialization uses uppercase letters, so instead this keeps it simple for the tests and stores the time in seconds.

Fixes #3355

@suzmue suzmue requested a review from a team as a code owner September 19, 2025 15:53
Copy link

codecov bot commented Sep 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.21%. Comparing base (355c5ba) to head (753283a).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3363      +/-   ##
==========================================
+ Coverage   96.19%   96.21%   +0.02%     
==========================================
  Files         115      115              
  Lines        4574     4574              
==========================================
+ Hits         4400     4401       +1     
+ Misses        174      173       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@suzmue suzmue merged commit 576ab46 into googleapis:main Sep 19, 2025
25 checks passed
@suzmue suzmue deleted the stale branch September 19, 2025 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set up integration tests to run against pubsub
2 participants