Skip to content

Conversation

westarle
Copy link
Contributor

for #3239

Copy link

codecov bot commented Sep 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.19%. Comparing base (576ab46) to head (4c5d278).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3367      +/-   ##
==========================================
- Coverage   96.21%   96.19%   -0.03%     
==========================================
  Files         115      115              
  Lines        4574     4574              
==========================================
- Hits         4401     4400       -1     
- Misses        173      174       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

coryan
coryan previously approved these changes Sep 19, 2025

/// Span Kind for OpenTelemetry interop. Always CLIENT for a span representing an outbound HTTP request.
const KEY_OTEL_KIND: &str = "otel.kind";
/// Span Name for OpenTelemetry interop. Recommended to be "{http.request.method} {url.template}" if url.template is available, otherwise "{http.request.method}".
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And I would avoid the passive voice, and format these differently:

Suggested change
/// Span Name for OpenTelemetry interop. Recommended to be "{http.request.method} {url.template}" if url.template is available, otherwise "{http.request.method}".
/// Span Name for OpenTelemetry interop.
///
/// If `url.template` is available use "{http.request.method} {url.template}", otherwise use "{http.request.method}".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, I updated all the docs, let me know if it's overkill.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@westarle westarle marked this pull request as ready for review September 19, 2025 21:03
@westarle westarle requested a review from a team as a code owner September 19, 2025 21:03
@westarle westarle merged commit 454b9a9 into googleapis:main Sep 19, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants