-
Notifications
You must be signed in to change notification settings - Fork 456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: GH-1375 Improve performance of NetHttpRequest write timeouts by provding a possibility to use custom threadpool #1494
base: main
Are you sure you want to change the base?
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it |
…g a possibility to use custom threadpool
f22bb2d
to
e622b5e
Compare
Any thoughts on this PR? 🤔 Not sure if I didn't fulfill the requirements of PR, because CI hangs or it's a change you don't want to have in the codebase in general. I'm asking, because it's over a half year and I still need to use self-compiled & distributed artifact with this fix as the current impl is pretty unusable in high throughput environment with configured timeouts. |
As described in #1375, creating a new thread per execution call pretty much kills the performance of application if it's oriented around high write throughput with configured write timeouts.
The proposed solution allows user to provide custom thread executor, so it's now user's responsibility to handle this kind of scenarios and because it doesn't introduce any kind of strange internal cached threadpool, it's also easier to maintain in the future.
Policy
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #1375 ☕️