Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: correct spelling of CDC in README #2400

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

docs: correct spelling of CDC in README #2400

wants to merge 1 commit into from

Conversation

norlove
Copy link

@norlove norlove commented Feb 6, 2024 •
edited
Loading

docs: correct spelling of CDC in README.
Making it more clear that this sample code is for BigQuery CDC (change data capture).

@norlove norlove requested review from a team as code owners February 6, 2024 19:49
@norlove norlove requested a review from Linchin February 6, 2024 19:49
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. labels Feb 6, 2024
@PhongChuong
Copy link
Contributor

Thanks for contributing. Can you update the PR to pass presubmit checks? I.e., conventionalcommits.org.

@norlove norlove changed the title Update README.md docs: correct spelling of CDC in README Feb 9, 2024
@conventional-commit-lint-gcf Conventional Commit Lint GCF
Copy link

conventional-commit-lint-gcf bot commented Feb 9, 2024 •
edited
Loading

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@norlove
Copy link
Author

norlove commented Feb 9, 2024

Thanks Phong, I believe I've corrected the issue you called out.
Let me know if anything else is outstanding.

@PhongChuong
Copy link
Contributor

Hi,
It's still failing conventionalcommits.org. I believe since the PR only has 1 commit, the commit message needs to match the PR message. Otherwise, this looks good to me.

@yirutang
Copy link
Contributor

The commit message can only be fix: or feat:?

@yirutang yirutang added the kokoro:run Add this label to force Kokoro to re-run the tests. label May 31, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhongChuong PhongChuong PhongChuong approved these changes

@yirutang yirutang yirutang approved these changes

@Linchin Linchin Awaiting requested review from Linchin Linchin is a code owner automatically assigned from googleapis/api-bigquery

Assignees
No one assigned
Labels
api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@norlove @PhongChuong @yirutang @yoshi-kokoro