feat(sidekick): Generate samples for single value setters #2263

amanda-tarafa · 2025-09-20T03:04:37Z

No description provided.

codecov · 2025-09-23T02:44:58Z

Codecov Report

❌ Patch coverage is 90.83333% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.15%. Comparing base (da69195) to head (99e4e8c).
⚠️ Report is 3 commits behind head on main.

Files with missing lines	Patch %	Lines
internal/sidekick/internal/api/xref.go	62.50%	4 Missing and 2 partials ⚠️
internal/sidekick/internal/rust/codec.go	50.00%	2 Missing and 1 partial ⚠️
internal/sidekick/internal/api/model.go	90.90%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2263      +/-   ##
==========================================
- Coverage   84.15%   84.15%   -0.01%     
==========================================
  Files          97       97              
  Lines        9794     9875      +81     
==========================================
+ Hits         8242     8310      +68     
- Misses       1206     1214       +8     
- Partials      346      351       +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

amanda-tarafa · 2025-09-23T02:46:22Z

This is now ready for review, with googleapis/google-cloud-rust#3369 as a counterpart.

coryan

A few nits and test improvements.

internal/sidekick/internal/api/model.go

internal/sidekick/internal/rust/templates/common/setter_preamble/singular_option.mustache

internal/sidekick/internal/rust/templates/common/setter_preamble/singular_value.mustache

internal/sidekick/internal/rust/templates/common/message.mustache

internal/sidekick/internal/rust/annotate.go

internal/sidekick/internal/rust/annotate_test.go

internal/sidekick/internal/api/xref.go

internal/sidekick/internal/rust/annotate_test.go

Towards [googleapis/google-cloud-rust#2689](googleapis/google-cloud-rust#2689)

Towards [googleapis/google-cloud-rust#2690](googleapis/google-cloud-rust#2690)

amanda-tarafa

All change requests addressed in the last commit.

internal/sidekick/internal/api/model.go

internal/sidekick/internal/rust/templates/common/setter_preamble/singular_option.mustache

internal/sidekick/internal/rust/templates/common/setter_preamble/singular_value.mustache

internal/sidekick/internal/rust/annotate.go

internal/sidekick/internal/api/xref.go

internal/sidekick/internal/rust/annotate_test.go

coryan · 2025-09-24T20:25:05Z

internal/sidekick/internal/api/model.go

+// IsEnum returns true if the primitive type of a field is `ENUM_TYPE`.
+//
+// This is useful for mustache templates that differ only
+// in the broad category of field type involved.
+func (f *Field) IsEnum() bool {
+	return f.Typez == ENUM_TYPE
+}


I think this change uncovered a number of bugs... Some of our mustache templates assumed this attribute was present, e.g.:

librarian/internal/sidekick/internal/rust/templates/convert-prost/oneof.mustache

Lines 38 to 43 in 014b5f4

{{^IsEnum}}

Self::{{Codec.BranchName}}(v) => Ok(T::from_{{Codec.SetterName}}(v.cnv()?)),

{{/IsEnum}}

{{#IsEnum}}

Self::{{Codec.BranchName}}(v) => Ok(T::from_{{Codec.SetterName}}(v)),

{{/IsEnum}}

But the attribute did not exist. Sigh... this is a thing I hate about the implementation of mustache templates in go.

Librarian Version: v0.0.0-20250925031739-cb21cf1ae8af Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/librarian-release-container:latest <details><summary>librarian: 0.3.0</summary> ## [0.3.0](v0.2.0...v0.3.0) (2025-09-25) ### Features * discovery-based APIs and pagination (#2350) ([cb21cf1](cb21cf1)) * Make generated `ProtoMessage` and `ProtoEnum` classes `final` (#2349) ([7d0520b](7d0520b)) * Require that all imports have a version contraints (#2331) Fixes #1989 This should not be landed before googleapis/google-cloud-rust#3396 ([00828d5](00828d5)) * Generate samples for single value setters (#2263) ([f7c0b84](f7c0b84)) * discovery doc arrays (#2337) ([da69195](da69195)) * Inject InstrumentationClientInfo for tracing (#2252) - Add static INSTRUMENTATION_CLIENT_INFO to lib.rs.mustache. - Use INSTRUMENTATION_CLIENT_INFO in transport.rs.mustache if tracing is enabled. For #2212 see also googleapis/google-cloud-rust#3347 and googleapis/google-cloud-rust#3376 ([1358226](1358226)) * parse most object fields (#2318) Parse most fields of object in a discovery doc. Fields with an inline type definition still need some custom work. ([f2d1a10](f2d1a10)) * Add the ability to insert text after the package title (#2323) The current use case for this is to advise users of equivalent Firebase packages. For example: ```toml readme-after-title-text = """> [!TIP] > Flutter applications should use [Firebase AI Logic](https://firebase.google.com/products/firebase-ai-logic). > > The Generate Language API is meant for Dart desktop and cloud applications. > Firebase AI Logic provides client-side access to both the Gemini Developer > API and Vertex AI. """ ``` Which results in a README.md that looks like: <img width="1485" height="909" alt="image" src="https://github.com/user-attachments/assets/a1c9120e-eafd-4394-9562-48c595ab4960" /> ([756e72f](756e72f)) ### Bug Fixes * read version from version.txt file (#2347) Fixes #2348 Moves version.txt to the `internal/cli` package so it can be read by the `embed` package as a variable. When constructing the synthetic version number, use this release version as the base. ([014b5f4](014b5f4)) * race condition in createWorkRoot() (#2338) Creating a temporary directory based on a timestamp is inherently racy. Use the standard functions to create temporary directories, and relax the tests to check for what matters. ([46428ca](46428ca)) * parse github remote from local directory (#2328) Fixes #2327 ([1c71bd9](1c71bd9)) </details>

amanda-tarafa force-pushed the setter-samples branch 2 times, most recently from 4de6483 to 7a2fdfa Compare September 23, 2025 02:40

amanda-tarafa marked this pull request as ready for review September 23, 2025 02:45

amanda-tarafa requested a review from a team as a code owner September 23, 2025 02:45

amanda-tarafa mentioned this pull request Sep 23, 2025

docs: Single value setter samples for Secret Manager and Workflows googleapis/google-cloud-rust#3369

Merged

coryan requested changes Sep 23, 2025

View reviewed changes

amanda-tarafa added 3 commits September 24, 2025 09:39

feat(sidekick): Flag for field setters sample generation.

b6e95e1

Towards [googleapis/google-cloud-rust#2689](googleapis/google-cloud-rust#2689)

feat(sidekick): Generate Rust samples for single field setters

381ffbf

Towards [googleapis/google-cloud-rust#2690](googleapis/google-cloud-rust#2690)

review(sidekick): Generate Rust samples for single field setters

99e4e8c

amanda-tarafa force-pushed the setter-samples branch from 7a2fdfa to 99e4e8c Compare September 24, 2025 16:42

amanda-tarafa commented Sep 24, 2025

View reviewed changes

coryan approved these changes Sep 24, 2025

View reviewed changes

amanda-tarafa merged commit f7c0b84 into googleapis:main Sep 24, 2025
6 checks passed

amanda-tarafa deleted the setter-samples branch September 24, 2025 17:45

coryan reviewed Sep 24, 2025

View reviewed changes

cloud-sdk-librarian-robot mentioned this pull request Sep 25, 2025

chore: librarian release pull request: 20250925T070206Z #2356

Merged

JoeWang1127 mentioned this pull request Sep 25, 2025

chore: librarian release pull request: 20250925T155209Z #2364

Closed

lqiu96 mentioned this pull request Sep 26, 2025

chore: librarian release pull request: 20250926T005936Z #2384

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(sidekick): Generate samples for single value setters #2263

feat(sidekick): Generate samples for single value setters #2263

Uh oh!

amanda-tarafa commented Sep 20, 2025

Uh oh!

codecov bot commented Sep 23, 2025 •

edited

Loading

Uh oh!

amanda-tarafa commented Sep 23, 2025

Uh oh!

coryan left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

amanda-tarafa left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

coryan Sep 24, 2025

Uh oh!

Uh oh!

	{{^IsEnum}}
	Self::{{Codec.BranchName}}(v) => Ok(T::from_{{Codec.SetterName}}(v.cnv()?)),
	{{/IsEnum}}
	{{#IsEnum}}
	Self::{{Codec.BranchName}}(v) => Ok(T::from_{{Codec.SetterName}}(v)),
	{{/IsEnum}}

feat(sidekick): Generate samples for single value setters #2263

feat(sidekick): Generate samples for single value setters #2263

Uh oh!

Conversation

amanda-tarafa commented Sep 20, 2025

Uh oh!

codecov bot commented Sep 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

amanda-tarafa commented Sep 23, 2025

Uh oh!

coryan left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

amanda-tarafa left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

coryan Sep 24, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

codecov bot commented Sep 23, 2025 •

edited

Loading