fix: a typo in chat session and missed toolConfig on chat start

PiperOrigin-RevId: 705975446
googleapis · Dec 13, 2024 · 03398ab · 03398ab
1 parent 029eb24
commit 03398ab
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/src/models/chat_session.ts b/src/models/chat_session.ts
@@ -128,7 +128,7 @@ export class ChatSession {
   ): Promise<GenerateContentResult> {
     const newContent: Content[] =
       formulateNewContentFromSendMessageRequest(request);
-    const generateContentrequest: GenerateContentRequest = {
+    const generateContentRequest: GenerateContentRequest = {
       contents: this.historyInternal.concat(newContent),
       safetySettings: this.safetySettings,
       generationConfig: this.generationConfig,
@@ -141,7 +141,7 @@ export class ChatSession {
       this.location,
       this.resourcePath,
       this.fetchToken(),
-      generateContentrequest,
+      generateContentRequest,
       this.apiEndpoint,
       this.generationConfig,
       this.safetySettings,

diff --git a/src/models/generative_models.ts b/src/models/generative_models.ts
@@ -268,6 +268,7 @@ export class GenerativeModel {
       startChatRequest.safetySettings =
         request.safetySettings ?? this.safetySettings;
       startChatRequest.tools = request.tools ?? this.tools;
+      startChatRequest.toolConfig = request.toolConfig ?? this.toolConfig;
       startChatRequest.apiEndpoint = request.apiEndpoint ?? this.apiEndpoint;
       startChatRequest.systemInstruction =
         request.systemInstruction ?? this.systemInstruction;
@@ -492,6 +493,7 @@ export class GenerativeModelPreview {
       publisherModelEndpoint: this.publisherModelEndpoint,
       resourcePath: this.resourcePath,
       tools: this.tools,
+      toolConfig: this.toolConfig,
       systemInstruction: this.systemInstruction,
       cachedContent: this.cachedContent?.name,
     };
@@ -503,6 +505,7 @@ export class GenerativeModelPreview {
       startChatRequest.safetySettings =
         request.safetySettings ?? this.safetySettings;
       startChatRequest.tools = request.tools ?? this.tools;
+      startChatRequest.toolConfig = request.toolConfig ?? this.toolConfig;
       startChatRequest.systemInstruction =
         request.systemInstruction ?? this.systemInstruction;
       startChatRequest.cachedContent =