Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix link in Part JSDoc #440

Merged
merged 2 commits into from
Oct 15, 2024
Merged

Conversation

WenHaozhan
Copy link
Contributor

No description provided.

@product-auto-label product-auto-label bot added the api: aiplatform Issues related to the googleapis/nodejs-vertexai API. label Oct 11, 2024
@yyyu-google yyyu-google changed the title Fixed link in Part JSDoc docs: Fix link in Part JSDoc Oct 15, 2024
Copy link

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

Copy link
Collaborator

@yyyu-google yyyu-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for fixing the doc string, could you update the commit message to be docs: Fix link in Part JSDoc?
Otherwise the commit message check will fail. thank you

@yyyu-google yyyu-google merged commit f497b18 into googleapis:main Oct 15, 2024
4 checks passed
copybara-service bot pushed a commit that referenced this pull request Oct 16, 2024
--
f8a3bdf by Oleksii Oleniuk <[email protected]>:

fix: Add Context Cache support for ChatSessionPreview class (#433)

* add content cache to chat session

* remove logs, add gitignore

---------

Co-authored-by: Oleksii Oleniuk <[email protected]>
Co-authored-by: Yvonne Yu <[email protected]>
--
64ac1a8 by Wenhao <[email protected]>:

Fixed link in Part JSDoc

COPYBARA_INTEGRATE_REVIEW=#440 from WenHaozhan:fix/part-jsdoc 16bb232
PiperOrigin-RevId: 686218863
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: aiplatform Issues related to the googleapis/nodejs-vertexai API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants