Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added
Document.from_gcs_multi()
method to get multiple wrapped documents from a GCS directory. #223feat: Added
Document.from_gcs_multi()
method to get multiple wrapped documents from a GCS directory. #223Changes from 3 commits
793763b
0bb2213
c342475
7cd3ac6
19b4d1f
04b66d0
4d5ba43
65d6b29
415c6e0
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is assuming that every sub-directory in the parent (bucket+prefix) is acceptable by
Document.from_gcs
, which I think has some validation checks.What is the desired behavior here if some of those sub-directories causes
Document.from_gcs
to fail? Should the wholelist_from_gcs
call fail, or should it return just whatever is successfully loaded (maybe along with some metadata explaining the failed items)?(Let's include unit tests for the case where one of the sub-directories contains wrong files.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
list_document_tree()
only outputs directories that contain JSON files. (However, it doesn't directly validate if they areDocument
JSON format.).from_gcs()
will throw aValueError
if a file is invalid. Or thedocumentai.Document.from_json()
method will throw an exception.It would probably make sense for this batch case to return whatever was successfully loaded and just skip files that throw exceptions. (And printing out or returning the failed files.)