-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: Support Django 4.2 #865
Conversation
) | ||
from django.db.models import JSONField | ||
USING_DJANGO_4 = False | ||
if django.VERSION[:2] == (4, 2): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as commented in this draft:
#860 (comment)
Currently Django 5 is released, since you are already working on it, can this field be override with a system environment, and make it something like:
if django.VERSION[:2] == (4, 2) or os.getenv('USING_DJANGO_4', 'false') == 'true'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry we cant do that as we are not sure how will Django 5 behave with this code.
Please feel free to create a fork and make changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can I second @jaz-la's request? If we can appropriately set expectations with the env car, what's the harm? I am currently using a fork that is hard to maintain with Django 5, and this PR includes everything that I have needed for Django 5 so far. Please?
Thanks again for all of your work.
thanks a lot for working on it, left a few comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you for working on it, I have been wanting to upgrade my django version for a long time and this is the last library that blocks me from doing so.
Co-authored-by: Knut Olav Løite <[email protected]>
Co-authored-by: Knut Olav Løite <[email protected]>
Co-authored-by: Knut Olav Løite <[email protected]>
Co-authored-by: Knut Olav Løite <[email protected]>
Breaking changes
AutoCommit=True
mode, the Spanner Django provider would not start a transaction.AutoCommit=True
mode, the Spanner Django provider will start a transaction.Release notes
AutoCommit=True
mode by default for V4.2. Transactions inAutoCommit=True
mode are by default not supported in prior versions (i.e. V3.2).AutoCommit=True
mode in V3.2, please setALLOW_TRANSACTIONS_IN_AUTO_COMMIT=True
your settings.py file.AutoCommit=True
mode in V4.2, please setALLOW_TRANSACTIONS_IN_AUTO_COMMIT=False
in your settings.py file.