Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to update / add to the user-agent for an existing client object #1327

Open
MattIrv opened this issue Jul 12, 2024 · 0 comments
Assignees
Labels
api: storage Issues related to the googleapis/python-storage API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@MattIrv
Copy link

MattIrv commented Jul 12, 2024

Is your feature request related to a problem? Please describe.

My team is using the Python storage client. When we initialize a new client, we set the user-agent as part of the client_info passed here. However, we'd like users to be able to pass in their own storage clients in order to do things like custom authentication or manage other options. Unfortunately the user-agent does not get set in this case, and there doesn't seem to be any way to edit or append to it for an existing client object.

Describe the solution you'd like

Provide a method or field on the Client object that we can use to edit or append to the user-agent for an existing Client object.

Describe alternatives you've considered

It may be possible for us to somehow duplicate the credentials / options / transport from an existing Client and create a new one and set the user-agent, but that seems error-prone.

Additional context

See our existing code on GitHub for an example of how we set the user-agent for a new client today.

@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/python-storage API. label Jul 12, 2024
@andrewsg andrewsg added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the googleapis/python-storage API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

2 participants