Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 13 additions & 7 deletions dependencies.txt
Original file line number Diff line number Diff line change
Expand Up @@ -3,26 +3,30 @@
# "1P" refers to First-Party dependencies (owned by Google).
# "3P" refers to Third-Party dependencies.

# Pom-Parent Dependencies (https://github.com/googleapis/sdk-platform-java/blob/main/gapic-generator-java-pom-parent/pom.xml)
# Pom-Parent Dependencies
# These dependencies are declared: https://github.com/googleapis/sdk-platform-java/blob/main/gapic-generator-java-pom-parent/pom.xml
javax.annotation-api=1.3.2
grpc=1.74.0
google.auth=1.37.1
google.http-client=1.47.1
gson=2.13.1
guava=33.4.8-jre
protobuf=4.31.1

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good addition for clarity.

{{SEVERITY}} low

# Note: This opentelemetry version refers to the opentelemetry-bom
opentelemetry=1.52.0
errorprone=2.41.0
j2objc-annotations=3.0.0
threetenbp=1.7.1
j2objc-annotations=3.1
threetenbp=1.7.2
slf4j=2.0.17

# 1P Shared-Deps (https://github.com/googleapis/sdk-platform-java/blob/main/java-shared-dependencies/first-party-dependencies/pom.xml)
# 1P Shared-Deps
# These dependencies are declared: https://github.com/googleapis/sdk-platform-java/blob/main/java-shared-dependencies/first-party-dependencies/pom.xml
grpc-gcp=1.6.1
google.oauth-client=1.39.0
google.api-client=2.8.0
google.api-client=2.8.1

# 3P Shared-Deps (https://github.com/googleapis/sdk-platform-java/blob/main/java-shared-dependencies/third-party-dependencies/pom.xml)
# 3P Shared-Deps
# These dependencies are declared: https://github.com/googleapis/sdk-platform-java/blob/main/java-shared-dependencies/third-party-dependencies/pom.xml
threeten-extra=1.8.0
opencensus=0.31.0
findbugs=3.0.2
Expand All @@ -33,10 +37,12 @@ httpcomponents.httpclient=4.5.14
apache-httpclient-5=5.5
apache-httpcore-5=5.3.4

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be slightly more consistent to phrase this comment like the others, for example: "Note: This opentelemetry version refers to the opentelemetry-bom, not the opentelemetry-exporter."

{{SEVERITY}} low

perfmark-api=0.27.0
# Note: This is the google opentelemetry exporter and not the general opentelemetry project
google.cloud.opentelemetry=0.36.0

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be clearer to say "The following opentelemetry dependencies..." for better readability.

{{SEVERITY}} low

opentelemetry-semconv=1.34.0
flogger=0.9
arrow=18.3.0
dev.cel=0.10.1
com.google.crypto.tink=1.18.0
# The follow opentelemetry dependencies have a different version from the opentelemetry-bom
opentelemetry-semconv=1.34.0
io.opentelemetry.contrib.opentelemetry-gcp-resources=1.48.0-alpha
Loading