Skip to content

fix(java): Add java 11 to release builds list #408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ldetmer wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix(java): Add java 11 to release builds list #408

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cdb2a01
was referencing wrong directory for ruby release build
ldetmer Oct 16, 2024
129797f
update node 14 builds to use support gcloud python version
ldetmer Oct 16, 2024
c3d36b4
revert uninteded change
ldetmer Oct 16, 2024
acf504a
additionally create java 11 release build used by publish docs ex: ja…
ldetmer Oct 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions java/cloudbuild-release.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,17 @@ steps:
["-i", "us-central1-docker.pkg.dev/$PROJECT_ID/release-images/java8", "--config", "java/java8.yaml", "-v"]
waitFor: ["java8-build"]

# Java 11 build for publish docs
- name: gcr.io/cloud-builders/docker
args: [ "build", "-t", "us-central1-docker.pkg.dev/$PROJECT_ID/release-images/java11", "." ]
dir: java/java11
id: java11-build
waitFor: [ "-" ]
- name: gcr.io/gcp-runtimes/structure_test
args:
[ "-i", "us-central1-docker.pkg.dev/$PROJECT_ID/release-images/java11", "--config", "java/java11.yaml", "-v" ]
waitFor: [ "java11-build" ]

# Java 17 build specifically for java-storage
- name: gcr.io/cloud-builders/docker
args: ["build", "-t", "us-central1-docker.pkg.dev/$PROJECT_ID/release-images/java17", "."]
Expand All @@ -38,6 +49,7 @@ steps:

images:
- us-central1-docker.pkg.dev/$PROJECT_ID/release-images/java8
- us-central1-docker.pkg.dev/$PROJECT_ID/release-images/java11
- us-central1-docker.pkg.dev/$PROJECT_ID/release-images/java17

options:
Expand Down
4 changes: 2 additions & 2 deletions node/14-user/Dockerfile
View file
Open in desktop
Copy link
Contributor

@chingor13 chingor13 Oct 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks accidentally checked in from a different PR

Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,8 @@ RUN echo 'export PATH="/home/node/.pyenv/bin:$PATH"' >> ~/.profile && \
ENV PATH="/home/node/.pyenv/bin:/home/node/.pyenv/shims:${PATH}"

# Install python
RUN pyenv install 3.7.4 && \
pyenv global 3.7.4 && \
RUN pyenv install 3.10.13 && \
pyenv global 3.10.13 && \
python3 -m pip install --upgrade pip setuptools

# Install gcp-uploader and gcp-releasetool and their dependencies.
Expand Down