This repository has been archived by the owner on Aug 25, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 77
Prepare to Firebase 3 upgrade #158
Open
jpventura
wants to merge
8
commits into
googlearchive:master
Choose a base branch
from
jpventura:prepare_to_firebase_upgrade
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Prepare to Firebase 3 upgrade #158
jpventura
wants to merge
8
commits into
googlearchive:master
from
jpventura:prepare_to_firebase_upgrade
Commits on Nov 21, 2016
-
🐛 Install npm and karma-cli on travis
Travis CI is falling because it is not finding npm and karma-cli in order to perform the tests (seems like they are not installed on the VMs). We just need configure before_install option at .travis.yml, ensuring that packages are present before starting the unit tests.
Configuration menu - View commit details
-
Copy full SHA for 29dbecb - Browse repository at this point
Copy the full SHA 29dbecbView commit details -
Minor .gitignore upgrade: - Remove duplicated folders - Upgrade list of automatically created files that should be ignored - Use GitHub Node.js .gitignore template (see https://goo.gl/hx0XE) - Also ignore Emacs and VSCode automatic files
Configuration menu - View commit details
-
Copy full SHA for 18c8365 - Browse repository at this point
Copy the full SHA 18c8365View commit details -
🐛 Upgrade karma development package
Update required in order to Travis CI run the unit tests
Configuration menu - View commit details
-
Copy full SHA for d3171a8 - Browse repository at this point
Copy the full SHA d3171a8View commit details -
Configuration menu - View commit details
-
Copy full SHA for c67b2de - Browse repository at this point
Copy the full SHA c67b2deView commit details -
📦 Update npm and bower package dependencies
Updated all package dependencies to its latest version, except Firebase and Backbone. This is an intermediary step before actually upgrading to latest backend version. Removed gulp-server and use gulp-contrib-connect instead (updating Gruntfile.js task also is required to perform the unit tests). We also installed chai and sinon because they are required by karma-chai and karma-sinon respectivelly.
Configuration menu - View commit details
-
Copy full SHA for 51b3788 - Browse repository at this point
Copy the full SHA 51b3788View commit details -
🐛 Fix Firebase.Collection#fetch test
Fix Backbone.Firebase.Collection#fetch test to properly check if a collection was successfully synced with Firebase backend.
Configuration menu - View commit details
-
Copy full SHA for ca2591d - Browse repository at this point
Copy the full SHA ca2591dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5afc302 - Browse repository at this point
Copy the full SHA 5afc302View commit details -
Configuration menu - View commit details
-
Copy full SHA for df6ee2d - Browse repository at this point
Copy the full SHA df6ee2dView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.