Fix missing } after function body in FF#20
Fix missing } after function body in FF#20svenpopping wants to merge 1 commit intogooglearchive:masterfrom svenpopping:patch-1
Conversation
The <html> and <body> tags will cause a ```SyntaxError: missing } after function body``` in FF 32.0, changing those to html and body will solve the problem.
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA) at https://cla.developers.google.com/. If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check the information on your CLA or see this help article on setting the email on your git commits. Once you've done that, please reply here to let us know. If you signed the CLA as a corporation, please let us know the company's name. |
|
I signed the CLA.
|
|
CLAs look good, thanks! |
|
Testing in FF stable and nightly I've been unable to verify that this is causing breakage. Is anyone else experiencing this? |
|
I can confirm that I am having this issue with Firefox version 36.0 on Ubuntu 14.10. I checked in Chrome Version 40.0.2214.115 (64-bit) on Ubuntu 14.10 and this issue does not present itself. I edited the two lines included in this pull request and it does indeed seem to solve the issue. |
4 participants
The
<html>and<body>tags in the comments will cause aSyntaxError: missing } after function bodyin FF 32.0, changing those into html and body will solve the problem.