This repository was archived by the owner on Mar 13, 2018. It is now read-only.
Makes dynamic sizing of core-dropdown possible#9
Open
rezonant wants to merge 1 commit intogooglearchive:masterfrom
Open
Makes dynamic sizing of core-dropdown possible#9rezonant wants to merge 1 commit intogooglearchive:masterfrom
rezonant wants to merge 1 commit intogooglearchive:masterfrom
Conversation
|
Before this PR can be merged, please sign the CLA. See the CONTRIBUTING guide. |
Author
|
Hello Eric, I had already signed the CLA. Should be on file with my github username. |
|
Verified. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the size of the dropdown is set in stone the first time the user views it. If the contents of the dropdown change in content or size later, the dropdown will not adjust. This is because measure() does not remove the width/height which is set from the results of measure() in previous runs, thus the size is always the "same".
In addition to this PR, I have pushed a fork of the current production tag (0.4.2) along with a patch onto:
https://github.com/rezonant/core-dropdown/tree/0.4.2_measurepatch.
Reproduction