Skip to content
This repository was archived by the owner on Mar 13, 2018. It is now read-only.

incorrect doc, core-overlay-open event detail.#51

Open
ulybu wants to merge 1 commit intogooglearchive:masterfrom
ulybu:incorrect_doc_core_overlay_open_event
Open

incorrect doc, core-overlay-open event detail.#51
ulybu wants to merge 1 commit intogooglearchive:masterfrom
ulybu:incorrect_doc_core_overlay_open_event

Conversation

@ulybu
Copy link

@ulybu ulybu commented Feb 2, 2015

event.detail is a boolean and not a object with an "opened" property
cf the openedChanged callback (line 366):

this.fire('core-overlay-open', this.opened);

Company-CLA signed : Hewlett-Packard

Event.detail is a boolean and not a object with an "opened" property
@googlebot
Copy link

Thanks for your pull request.

It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA) at https://cla.developers.google.com/.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check the information on your CLA or see this help article on setting the email on your git commits.

Once you've done that, please reply here to let us know. If you signed the CLA as a corporation, please let us know the company's name.

@ulybu
Copy link
Author

ulybu commented Feb 10, 2015

Fixes #48

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants