Skip to content
This repository has been archived by the owner on Sep 7, 2022. It is now read-only.

Enabled sending of user properties #310

Merged
merged 6 commits into from
Apr 1, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
## 7.2.2-dev

- Enabled sending of user properties in analytics with `setUserProperties`.
- Removed unused (and unusable) `CustomParams` class.

## 7.2.1

- Mark intereop types `AuthProvider` and `OAuthCredential` anonymous.
Expand Down
12 changes: 3 additions & 9 deletions lib/src/analytics.dart
Original file line number Diff line number Diff line change
Expand Up @@ -44,12 +44,12 @@ class Analytics extends JsObjectWrapper<analytics_interop.AnalyticsJsImpl> {
}
}

void setUserProperties(CustomParams properties,
void setUserProperties(Map<String, String> properties,
kevmoo marked this conversation as resolved.
Show resolved Hide resolved
[AnalyticsCallOptions options]) {
if (options != null) {
jsObject.setUserProperties(properties.jsObject, options.jsObject);
jsObject.setUserProperties(jsify(properties), options.jsObject);
} else {
jsObject.setUserProperties(properties.jsObject);
jsObject.setUserProperties(jsify(properties));
}
}
}
Expand All @@ -65,9 +65,3 @@ class AnalyticsCallOptions
jsObject.global = t;
}
}

class CustomParams
extends JsObjectWrapper<analytics_interop.CustomParamsJsImpl> {
CustomParams._fromJsObject(analytics_interop.CustomParamsJsImpl jsObject)
: super.fromJsObject(jsObject);
}
7 changes: 1 addition & 6 deletions lib/src/interop/analytics_interop.dart
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ abstract class AnalyticsJsImpl {
external void setCurrentScreen(String screenName,
[AnalyticsCallOptionsJsImpl options]);
external void setUserId(String id, [AnalyticsCallOptionsJsImpl options]);
external void setUserProperties(CustomParamsJsImpl properties,
external void setUserProperties(Object properties,
[AnalyticsCallOptionsJsImpl options]);
}

Expand All @@ -23,8 +23,3 @@ class AnalyticsCallOptionsJsImpl {

external factory AnalyticsCallOptionsJsImpl({bool global});
}

@JS('CustomParams')
class CustomParamsJsImpl {
//TODO: implement
}
2 changes: 1 addition & 1 deletion pubspec.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: firebase
description: Firebase libraries for Dart on the web and server
version: 7.2.1
version: 7.2.2-dev
homepage: https://github.com/FirebaseExtended/firebase-dart

environment:
Expand Down