This repository was archived by the owner on Dec 15, 2018. It is now read-only.
added an option for building a close button...#9
Open
capaj wants to merge 4 commits intogooglearchive:gh-pagesfrom
Open
added an option for building a close button...#9capaj wants to merge 4 commits intogooglearchive:gh-pagesfrom
capaj wants to merge 4 commits intogooglearchive:gh-pagesfrom
Conversation
Contributor
|
I have a few comments about this PR, but it's very similar in functionality to #8. Could you add comments to that PR if you think it needs work? Or alternatively, base your work upon that branch? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
with a custom buildCloseBtn function passed in options. Also added a package.json and recompiled the compiled file with UglifyJS