[WIP] Building blocks for shape reuse #102
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsheeter
force-pushed
the
reuse1
branch
2 times, most recently
from
3595a68
to
741d809
Compare
rsheeter
force-pushed
the
reuse1
branch
2 times, most recently
from
0a0789d
to
8ce2df0
Compare
rsheeter
force-pushed
the
reuse1
branch
2 times, most recently
from
53f1f7f
to
727c59c
Compare
rsheeter
force-pushed
the
reuse1
branch
2 times, most recently
from
6b43d24
to
a3dc226
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on work to move IR to
kurbo::BezPathas that makes the manipulations for reuse much more natural.TODO: BezPath doesn't support arc, what do we do about that? - it will matter when we reach Noto Emoji. Since the font format does not, and for the forseeable future will not, support arc maybe normalizing arcs that became cubics is ok?
Name shape-brokkr continues the Norse theme and honors https://en.wikipedia.org/wiki/Brokkr.