-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CJK metrics #159
base: main
Are you sure you want to change the base?
CJK metrics #159
Conversation
better positioning and some adjusted language
Also if the em-box information in the OS/2.sTypo* of the original spec is to be retained in BASE table, then the horizontal |
Given the high expectations from major softwares that |
Thanks for the comments! I'll take a look to update the documentation with your feedback :) |
I don't think it is absolutely necessary to include |
Updating based on feedback from NightFury and to clarify the situation around the vmtx / vhea tables.
one other thing is i think "em-box" is the better convention here in text rather than "emBox"; it's what used in the Microsoft OpenType Spec docs. |
changing naming
adding further information about the vhea / vmtx table and how to set them correctly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work! Happy for this to be merged. We can always improve it if needed but imo it's much better than the original implementation.
A few more things:
|
Hm. Initially, I thought that it would make sense to include something like this, but I think that it feels a bit like telling people how to set their cap height or x-height values. I don't think that GF has an opinion about where the em-box is placed in the font space, just that the metrics are set in a certain way. Wouldn't most type designers have a sense about how to do this, or can reference other guidance? I don't know if it is a QA issue, essentially.
I've included them based on what Adobe puts into their fonts, and since the
Generally the
Isn't that what I've already stated by indicating that the hhea values should be set to align with the sTypo values? |
The main 3editors have varying support. FontLab straight up doesn't support vhea/vmtx and does not plan to support CJK anytime soon. FontCreator sets the advance height per glyph like the advance width. From what is observed here, Glyphs uses the AFDKO table syntax (?) for overrides.
I mean as in a multi-weight family such as Source Han, but given the old hhea reference to the highest glyph, maybe it should be the usWin values for the new metrics here that should be harmonised across the typeface family. |
Updated the recommendation regarding CJK metrics reflective of our discussion on the matter.
Let me know if you feel more information / justification is required!