Make it possible to have custom name for anchors in cursFeatureWriter.

[typoman]

No description provided.

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[anthrotype]

maybe better to have an options dict so you don't need to subclass to modify entry/exit anchor names, you simply pass the desired names to the default constructor as keyword arguments:

class CursFeatureWriter(BaseFeatureWriter):
    ...
    options = dict(entry="entry", exit="exit")    

Then you make an instance of CursFeatureWriter(entry="foobar", exit="baz")

KernFeatureWriter has a similar thing for ignoreMarks:

ufo2ft/Lib/ufo2ft/featureWriters/kernFeatureWriter.py

Line 110 in 236096c

options = dict(ignoreMarks=True, quantization=1)

[anthrotype]

The parent BaseFeatureWriters automatically turns that options dict attribute of the class into a self.options namespace, see

ufo2ft/Lib/ufo2ft/featureWriters/baseFeatureWriter.py

Lines 59 to 64 in 236096c

	options = dict(self.__class__.options)
	for k in kwargs:
	if k not in options:
	raise TypeError("unsupported keyword argument: %r" % k)
	options[k] = kwargs[k]
	self.options = SimpleNamespace(**options)

[anthrotype]

an additional advantange of using options dict, is that the custom entry/exit anchor names can be encoded as options directly in the featureWriters lib key.

<dict>
    <key>com.github.googlei18n.ufo2ft.featureWriters</key>
    <array>
        <dict>
            <key>class</key>
            <string>CursFeatureWriter</string>
            <key>options</key>
            <dict>
                <key>entry</key>
                <string>foobar</string>
                <key>exit</key>
                <string>baz</string>
            </dict>
        </dict>
    </array>
</dict>

[anthrotype]

if you use the options dict like I suggested above, you can then use these as self.options.entry or self.options.exit etc.

[khaledhosny]

FWIW, Glyphs app supports multiple exit/entry pairs (e.g. exit_1/entry_1 etc.) and we want to eventually support this, so it should be kept in mind when designing API now so we do}t have to do breaking changes later or awkward workarounds.

[anthrotype]

multiple exit/entry pairs (e.g. exit_1/entry_1 etc.)

how do these works?

[khaledhosny]

multiple exit/entry pairs (e.g. exit_1/entry_1 etc.)

how do these works?

I don’t know yet (that is the eventually bit). It is on my radar, but I don’t currently have a font that need this (I had one, but I painstakingly forced it to use a single exit/entry pair when I ported it from FontForge to Glyphs, before Glyphs app had this).