Skip to content

Commit

Permalink
Updated typo's in multiple files (#4055)
Browse files Browse the repository at this point in the history
* Update release_issue.md

* Commit
  • Loading branch information
nallave authored Dec 3, 2024
1 parent cd9b7a1 commit def4351
Show file tree
Hide file tree
Showing 6 changed files with 10 additions and 10 deletions.
2 changes: 1 addition & 1 deletion docs/governance/templates/release_issue.md
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ and copy it into a release issue. Fill in relevant values, found inside {}
- [ ] Run `make post-build-release` to build the artifacts in GCS(These files will be attached in the release notes) and to push the latest images in the release repository and push chart on agones-chart.
- [ ] Run `make shell` and run `gcloud config configurations activate <your development project>` to switch Agones
development tooling off of the `agones-images` project.
- [ ] Smoke Test: run `make install-release` to view helm releases, uninstall agones-system namesapce, fetch the latest version of Agones, verify the new version, installing agones-system namespace, and list all the pods of agones-system.
- [ ] Smoke Test: run `make install-release` to view helm releases, uninstall agones-system namespace, fetch the latest version of Agones, verify the new version, installing agones-system namespace, and list all the pods of agones-system.
- [ ] Attach all assets found in the cloud storage with {version} to the draft GitHub Release.
- [ ] Copy any review changes from the release blog post into the draft GitHub release.
- [ ] Publish the draft GitHub Release.
Expand Down
2 changes: 1 addition & 1 deletion examples/allocation-endpoint/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ helm upgrade my-release --install --namespace agones-system --create-namespace a
--set agones.allocator.service.http.enabled=false
```

After installing Agones, deploy [ESP](https://cloud.google.com/endpoints/docs/grpc/specify-esp-v2-startup-options) which is an envoy based proxy, deployed as a sidecar along side `agones-alloator` container. Run the following to patch the service deployement, change the service port to ESP and add annotation to `agones-allocator` service account to impersonate GCP service account.
After installing Agones, deploy [ESP](https://cloud.google.com/endpoints/docs/grpc/specify-esp-v2-startup-options) which is an envoy based proxy, deployed as a sidecar along side `agones-alloator` container. Run the following to patch the service deployment, change the service port to ESP and add annotation to `agones-allocator` service account to impersonate GCP service account.

Replace [GKE-PROJECT-ID] in `patch-agones-allocator.yaml` with your project ID before running the scripts.

Expand Down
2 changes: 1 addition & 1 deletion examples/allocator-client-csharp/Program.cs
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ class Program
static async Task Main(string[] args)
{
if (args.Length < 6) {
throw new Exception("Arguments are missing. Expecting: <private key> <public key> <server CA> <external IP> <namepace> <enable multi-cluster>");
throw new Exception("Arguments are missing. Expecting: <private key> <public key> <server CA> <external IP> <namespace> <enable multi-cluster>");
}

string clientKey = File.ReadAllText(args[0]);
Expand Down
4 changes: 2 additions & 2 deletions examples/simple-game-server/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,8 @@ There are some text commands you can send the server to affect its behavior:
| "LIST_CONTAINS" | Returns true if the given value is in the given List, false otherwise |
| "GET_LIST_LENGTH" | Returns the length (number of values) of the given List as a string |
| "GET_LIST_VALUES" | Return the values in the given List as a comma delineated string |
| "APPEND_LIST_VALUE" | Returns if the given value was successfuly added to the List (true) or not (false) |
| "DELETE_LIST_VALUE" | Rreturns if the given value was successfuly deleted from the List (true) or not (false) |
| "APPEND_LIST_VALUE" | Returns if the given value was successfully added to the List (true) or not (false) |
| "DELETE_LIST_VALUE" | Rreturns if the given value was successfully deleted from the List (true) or not (false) |

## Configuration

Expand Down
6 changes: 3 additions & 3 deletions examples/simple-game-server/handlers.go
Original file line number Diff line number Diff line change
Expand Up @@ -283,7 +283,7 @@ func handlePlayerConnected(s *sdk.SDK, parts []string, _ ...context.CancelFunc)
return
}

// handleGetPlayers returns a comma delimeted list of connected players
// handleGetPlayers returns a comma delimited list of connected players
func handleGetPlayers(s *sdk.SDK, parts []string, _ ...context.CancelFunc) (response string, addACK bool, responseError error) {
log.Print("Retrieving connected player list")
list, err := s.Alpha().GetConnectedPlayers()
Expand Down Expand Up @@ -535,7 +535,7 @@ func handleGetListValues(s *sdk.SDK, parts []string, _ ...context.CancelFunc) (r
return
}

// handleAppendListValue returns if the given value was successfuly added to the List or not
// handleAppendListValue returns if the given value was successfully added to the List or not
func handleAppendListValue(s *sdk.SDK, parts []string, _ ...context.CancelFunc) (response string, addACK bool, responseError error) {
if len(parts) < 3 {
response = "Invalid APPEND_LIST_VALUE, should have 2 arguments"
Expand All @@ -553,7 +553,7 @@ func handleAppendListValue(s *sdk.SDK, parts []string, _ ...context.CancelFunc)
return
}

// handleDeleteListValue returns if the given value was successfuly deleted from the List or not
// handleDeleteListValue returns if the given value was successfully deleted from the List or not
func handleDeleteListValue(s *sdk.SDK, parts []string, _ ...context.CancelFunc) (response string, addACK bool, responseError error) {
if len(parts) < 3 {
response = "Invalid DELETE_LIST_VALUE, should have 2 arguments"
Expand Down
4 changes: 2 additions & 2 deletions examples/simple-genai-server/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,7 @@ type Message struct {
func handleGenAIRequest(prompt string, clientConn *connection, chatHistory []Message) (string, error) {
var jsonStr []byte
var err error
// If the endpoint is the NPC API, use the json request format specifc to that API
// If the endpoint is the NPC API, use the json request format specific to that API
if clientConn.npc {
npcRequest := NPCRequest{
Msg: prompt,
Expand Down Expand Up @@ -329,7 +329,7 @@ func autonomousChat(prompt string, conn1 *connection, conn2 *connection, numChat
autonomousChat(response, conn2, conn1, numChats, stopPhase, chatHistory)
}

// Manually interact via TCP with the GenAI endpont
// Manually interact via TCP with the GenAI endpoint
func tcpListener(port string, genAiConn *connection) {
log.Printf("Starting TCP server, listening on port %s", port)
ln, err := net.Listen("tcp", ":"+port)
Expand Down

0 comments on commit def4351

Please sign in to comment.