-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sdkserver.SetAnnotations() #4001
base: main
Are you sure you want to change the base?
Conversation
Build Failed 😭 Build Id: 6bf71540-b245-4e61-a9e4-b060d4c5a439 Status: FAILURE To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
5a79a1f
to
997fe74
Compare
Build Failed 😭 Build Id: 4be80e2b-ce52-4a3b-b113-ded3b0847aa4 Status: FAILURE To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
Build Failed 😭 Build Id: d5428209-06d1-4b09-8673-507abfd93b46 Status: FAILURE To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
8127ad3
to
c9c6f70
Compare
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
Build Failed 😭 Build Id: d8486e17-18fa-48fc-ac9d-6a6fbfad2fa8 Status: FAILURE To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
lint error
|
Build Failed 😭 Build Id: afe1b1c2-f118-4317-91c2-144a4f4d046f Status: FAILURE To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
/gcbrun |
Build Succeeded 🥳 Build Id: 04c928c9-b679-4dce-91f3-4e0622d4767c The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
9113391
to
f91758f
Compare
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
What type of PR is this?
/kind feature
What this PR does / Why we need it:
Provides the ability to set multiple annotations at once.
This is important if you want an atomic application of the annotations.
Without that, setting annotations is not atomic, so anyone watching for changes required a mechanism to find out when all annotations have been applied. Hard to do if the number of annotation varies.
Which issue(s) this PR fixes:
Closes #3835
Special notes for your reviewer:
Adding some notes in the related ticket around unsetting annotations and labels.