Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete List Value(s) on Game Server Allocation #4054

Merged
merged 10 commits into from
Dec 13, 2024

Conversation

igooch
Copy link
Collaborator

@igooch igooch commented Dec 2, 2024

What type of PR is this?

/kind feature

What this PR does / Why we need it:

Adds the ability to delete value(s) from a List during game server allocation.

Which issue(s) this PR fixes:

Closes #4003

Special notes for your reviewer:

Commits have been broken out into the different parts of this PR. Follows the existing code for AddValues during game server allocation.

@github-actions github-actions bot added kind/feature New features for Agones size/M labels Dec 2, 2024
@agones-bot
Copy link
Collaborator

Build Failed 😭

Build Id: 47d4b269-fe90-4424-9b8f-6ba839d0acac

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@igooch igooch force-pushed the delete-on-allocate branch from 776e19c to a24c85a Compare December 2, 2024 23:09
@agones-bot
Copy link
Collaborator

Build Failed 😭

Build Id: f2a8871d-a4e1-4bef-8389-61062455862c

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@igooch igooch force-pushed the delete-on-allocate branch from a24c85a to 9786b90 Compare December 2, 2024 23:23
@agones-bot
Copy link
Collaborator

Build Failed 😭

Build Id: 17830196-457e-46df-879e-edf90781c394

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: f5386a51-2f6c-47e1-a361-6c23e4d77a5b

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4054/head:pr_4054 && git checkout pr_4054
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.46.0-dev-9786b90

@agones-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: 92ea4d8f-27a0-4c0c-830b-88af543ded89

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4054/head:pr_4054 && git checkout pr_4054
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.46.0-dev-730ac2c

Copy link
Collaborator

@gongmax gongmax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, some minor comments

pkg/apis/agones/v1/gameserver.go Show resolved Hide resolved
proto/allocation/allocation.proto Show resolved Hide resolved
@agones-bot
Copy link
Collaborator

Build Failed 😭

Build Id: 83966ad6-da24-4865-a393-14f622fe8d69

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Failed 😭

Build Id: 1dccaa11-64ab-4970-8e74-61d1a96c009f

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@gongmax gongmax enabled auto-merge (squash) December 12, 2024 23:27
@agones-bot
Copy link
Collaborator

Build Failed 😭

Build Id: ab299876-0f03-4d59-833c-a8a69dbdf787

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: 180054e6-2378-4201-b5fa-5934a1d99178

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4054/head:pr_4054 && git checkout pr_4054
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.46.0-dev-d9186e0

@gongmax gongmax merged commit 3c5b7df into googleforgames:main Dec 13, 2024
4 checks passed
@igooch igooch deleted the delete-on-allocate branch December 20, 2024 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New features for Agones size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance AllocationSpec List modification to include delete operation
3 participants