-
Notifications
You must be signed in to change notification settings - Fork 823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete List Value(s) on Game Server Allocation #4054
Conversation
Build Failed 😭 Build Id: 47d4b269-fe90-4424-9b8f-6ba839d0acac Status: FAILURE To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
776e19c
to
a24c85a
Compare
Build Failed 😭 Build Id: f2a8871d-a4e1-4bef-8389-61062455862c Status: FAILURE To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
a24c85a
to
9786b90
Compare
Build Failed 😭 Build Id: 17830196-457e-46df-879e-edf90781c394 Status: FAILURE To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
Build Succeeded 🥳 Build Id: f5386a51-2f6c-47e1-a361-6c23e4d77a5b The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
Build Succeeded 🥳 Build Id: 92ea4d8f-27a0-4c0c-830b-88af543ded89 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, some minor comments
Build Failed 😭 Build Id: 83966ad6-da24-4865-a393-14f622fe8d69 Status: FAILURE To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
Build Failed 😭 Build Id: 1dccaa11-64ab-4970-8e74-61d1a96c009f Status: FAILURE To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
Build Failed 😭 Build Id: ab299876-0f03-4d59-833c-a8a69dbdf787 Status: FAILURE To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
Build Succeeded 🥳 Build Id: 180054e6-2378-4201-b5fa-5934a1d99178 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
What type of PR is this?
/kind feature
What this PR does / Why we need it:
Adds the ability to delete value(s) from a List during game server allocation.
Which issue(s) this PR fixes:
Closes #4003
Special notes for your reviewer:
Commits have been broken out into the different parts of this PR. Follows the existing code for AddValues during game server allocation.