Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes build error in push-upgrade-test #4065

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

igooch
Copy link
Collaborator

@igooch igooch commented Dec 12, 2024

What type of PR is this?

/kind hotfix

What this PR does / Why we need it:

Fixes build error k8s.io/[email protected] requires go >= 1.23.0 (running go 1.22.9; GOTOOLCHAIN=local). Running go mod tidy as part of the Dockerfile build updated the go.mod file to use go version 1.23 even though the builder uses golang version 1.22, which causes a versioning conflict.

Fix hard codes Golang version (an explicit go.mod file) so that there is no conflict between the Docker builder golang version and the go.mod version. Also updates the test/upgrade golang version to be the same golang version as the rest of the Agones project.

Which issue(s) this PR fixes:

NA

Special notes for your reviewer:

I will create a second issue to upgrade Golang in general, since 1.23 has been out for a while we should upgrade.

@igooch igooch requested a review from gongmax December 12, 2024 21:37
@github-actions github-actions bot added kind/hotfix Hotfixes for issues against release size/L labels Dec 12, 2024
@agones-bot
Copy link
Collaborator

Build Failed 😭

Build Id: 6ee97508-ba10-4e80-9549-cbc0f1ede586

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@gongmax
Copy link
Collaborator

gongmax commented Dec 12, 2024

/gcbrun

@agones-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: 617ccf3c-2ebd-4949-8777-f7a54d2e4929

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4065/head:pr_4065 && git checkout pr_4065
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.46.0-dev-bed5a31

@gongmax gongmax merged commit ccca32a into googleforgames:main Dec 13, 2024
4 checks passed
@igooch igooch deleted the fix-go-toolchain-error branch December 20, 2024 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/hotfix Hotfixes for issues against release size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants