Fixes build error in push-upgrade-test #4065
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind hotfix
What this PR does / Why we need it:
Fixes build error
k8s.io/[email protected] requires go >= 1.23.0 (running go 1.22.9; GOTOOLCHAIN=local)
. Runninggo mod tidy
as part of the Dockerfile build updated thego.mod
file to use go version 1.23 even though the builder uses golang version 1.22, which causes a versioning conflict.Fix hard codes Golang version (an explicit go.mod file) so that there is no conflict between the Docker builder golang version and the go.mod version. Also updates the test/upgrade golang version to be the same golang version as the rest of the Agones project.
Which issue(s) this PR fixes:
NA
Special notes for your reviewer:
I will create a second issue to upgrade Golang in general, since 1.23 has been out for a while we should upgrade.