feat(helm): support dual-stack networking for load balancers #4073
+36
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/gcbrun |
|
Build Succeeded 🥳 Build Id: f4b94cec-bbc6-4dfe-adae-4b78994cf43f The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version: |
gongmax
reviewed
Dec 20, 2024
There was a problem hiding this comment.
Please also add descriptions in the relevant tables in https://github.com/googleforgames/agones/blob/main/site/content/en/docs/Installation/Install%20Agones/helm.md?plain=1
install/helm/agones/values.yaml
Outdated
Comment on lines
189
to
192
| # ipFamilyPolicy: RequireDualStack | ||
| # ipFamilies: | ||
| # - IPv4 | ||
| # - IPv6 |
There was a problem hiding this comment.
Instead of commenting out these settings, can we set them to empty values?
There was a problem hiding this comment.
What about setting them to the default values?
ipFamilyPolicy: SingleStack
ipFamilies:
- IPv4
install/helm/agones/values.yaml
Outdated
Comment on lines
202
to
205
| # ipFamilyPolicy: RequireDualStack | ||
| # ipFamilies: | ||
| # - IPv4 | ||
| # - IPv6 |
install/helm/agones/values.yaml
Outdated
Comment on lines
249
to
252
| # ipFamilyPolicy: RequireDualStack | ||
| # ipFamilies: | ||
| # - IPv4 | ||
| # - IPv6 |
bergemalm
force-pushed
the
feat/support-dual-stack-lbs
branch
from
781e4bd to
ac56c52
Compare
|
PR updated. Descriptions added and empty values set. @gongmax |
bergemalm
force-pushed
the
feat/support-dual-stack-lbs
branch
from
ac56c52 to
a04ccc8
Compare
|
/gcbrun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / Why we need it:
This PR adds support for setting up dual-stack load balancers (IPv4 and IPv6).