Unity SDK: Delay dispose of CancellationTokenSource when quitting #4075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quitting in Unity fires a number of events and callbacks. `MonoBehaviour.OnApplicationQuit` is called before `Application.wantsToQuit` which leads to undesired behaviour. `Application.wantsToQuit` can be used to interrupt a quit process, so you can shut down gracefully. If this is utilized, the AgonesSDK has already dispose the cancellation token and future calls will fail. Reference: https://docs.unity3d.com/6000.0/Documentation/ScriptReference/Application-wantsToQuit.html Same solution as in UniRX: neuecc/UniRx#463
|
/gcbrun |
|
Build Succeeded 🥳 Build Id: 80def32a-2120-4a72-9f4d-2e45d0648ef0 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / Why we need it:
Quitting in Unity fires a number of events and callbacks.
MonoBehaviour.OnApplicationQuitis called beforeApplication.wantsToQuitwhich leads to undesired behaviour.Application.wantsToQuitcan be used to interrupt a quit process, so you can shut down gracefully. If this is utilized, the AgonesSDK has already disposed the cancellation token and future calls will fail.We use this when controlling disruption https://agones.dev/site/docs/advanced/controlling-disruption/
Reference: https://docs.unity3d.com/6000.0/Documentation/ScriptReference/Application-wantsToQuit.html
Same solution as in UniRX: neuecc/UniRx#463
Which issue(s) this PR fixes:
Closes #
Special notes for your reviewer: