Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow service initialization to fail #1096

Merged
merged 2 commits into from
Feb 5, 2025
Merged

Allow service initialization to fail #1096

merged 2 commits into from
Feb 5, 2025

Conversation

Jake-Shadle
Copy link
Collaborator

This actually bubbles up service initialization errors rather than silently swallowing them, leaving them in an unknown state.

@quilkin-bot
Copy link
Collaborator

Build Succeeded 🥳

Build Id: e188cde6-128f-4bad-9be3-4c7faa02cc6f

The following development images have been built, and will exist for the next 30 days:

To build this version:

git fetch [email protected]:googleforgames/quilkin.git pull/1096/head:pr_1096 && git checkout pr_1096
cargo build

@Jake-Shadle Jake-Shadle merged commit 956024d into main Feb 5, 2025
12 checks passed
@XAMPPRocky XAMPPRocky deleted the fix-service-errors branch February 5, 2025 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants