Ignore normal errors #1135
Merged
Ignore normal errors #1135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm not sure this closes the issue, because we have tied this error to packet loss errors in the game, and this PR doesn't seem to address whatever is ocurring with the error. it's just adding the metric. |
This is something we don't handle since it's not a good idea to do this, but good to know if it does happen so that we can add handling of it if we need to
For now we can increment this in all cases, but we can filter out the ones that can happen in normal operation if it is just noise Also adds a small helper to eliminate allocations in the common cases
|
Build Succeeded 🥳 Build Id: 6da3f06c-eeca-476b-a618-94713fcd824f The following development images have been built, and will exist for the next 30 days: To build this version: |
XAMPPRocky
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1133