Skip to content

chore: Add @MainActor annotations for Swift 6 concurrency [Phase 2] - #254

Merged
boilerwadding merged 1 commit into
mainfrom
SB/fix-warnings-concurrency-p2
May 13, 2026
Merged

chore: Add @MainActor annotations for Swift 6 concurrency [Phase 2]#254
boilerwadding merged 1 commit into
mainfrom
SB/fix-warnings-concurrency-p2

Conversation

@iHackSubhodip

@iHackSubhodip iHackSubhodip commented May 6, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Continues Swift 6 concurrency migration by adding @MainActor annotations to delegate implementations and UI-related classes
  • Fixes MainActor isolation warnings in 4 view controllers
  • Ensures thread safety for UI operations in delegate methods

Changes Made

  • AnimatedCurrentLocationViewController: Added @MainActor to CLLocationManagerDelegate extension
  • CustomIndoorViewController: Added @MainActor to GMSIndoorDisplayDelegate extension
  • DataDrivenStylingBasicViewController: Added @MainActor to SliderControls class and addSliderAndLabel static method
  • DataDrivenStylingSearchViewController: Added @MainActor to PlaceLookupController class

Test Plan

  • Verify no Swift 6 concurrency warnings in modified files
  • Ensure existing functionality remains unchanged
  • Test delegate methods respond correctly to user interactions
  • Confirm UI updates happen on main thread
Simulator Screenshot - iPhone 17 - 2026-05-06 at 10 08 50 Simulator Screenshot - iPhone 17 - 2026-05-06 at 10 08 56

@boilerwadding
boilerwadding merged commit d712a9c into main May 13, 2026
19 checks passed
@boilerwadding
boilerwadding deleted the SB/fix-warnings-concurrency-p2 branch May 13, 2026 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants