Skip to content

🧪 Add test for EncryptedTokenStorage::new#17

Merged
jpoehnelt merged 2 commits intomainfrom
fix-token-storage-tests-11276594267652718308
Mar 3, 2026
Merged

🧪 Add test for EncryptedTokenStorage::new#17
jpoehnelt merged 2 commits intomainfrom
fix-token-storage-tests-11276594267652718308

Conversation

@jpoehnelt
Copy link
Copy Markdown
Member

🎯 What: The EncryptedTokenStorage::new function in src/token_storage.rs was untested.
📊 Coverage: A new unit test was added to verify that EncryptedTokenStorage::new properly initializes the file_path and cache fields, specifically asserting the empty state of the async Mutex.
Result: Test coverage improved for the EncryptedTokenStorage constructor. All tests run successfully.


PR created automatically by Jules for task 11276594267652718308 started by @jpoehnelt

Co-authored-by: jpoehnelt <3392975+jpoehnelt@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 3, 2026

🦋 Changeset detected

Latest commit: a7a7103

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@googleworkspace/cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the robustness of the token storage mechanism by introducing a dedicated unit test for the constructor of EncryptedTokenStorage. The new test ensures that the essential internal components are correctly set up upon instantiation, thereby preventing potential issues related to uninitialized states and improving overall code reliability.

Highlights

  • New Unit Test: A new unit test was added for the EncryptedTokenStorage::new function in src/token_storage.rs.
  • Initialization Verification: The test verifies that EncryptedTokenStorage::new correctly initializes the file_path and cache fields, specifically asserting the empty state of the async Mutex.
  • Test Coverage: This change improves test coverage for the EncryptedTokenStorage constructor.
Changelog
  • .changeset/test-encrypted-token-storage-new.md
    • Added a new changeset file.
  • src/token_storage.rs
    • Added a new test module #[cfg(test)] mod tests.
    • Implemented test_encrypted_token_storage_new to verify the initialization of file_path and cache.
Activity
  • PR created automatically by Jules for task 11276594267652718308, started by @jpoehnelt.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a unit test for the EncryptedTokenStorage::new function. The test correctly verifies that the file_path and cache fields are initialized as expected. The implementation is sound and improves test coverage. I have no further comments.

Co-authored-by: jpoehnelt <3392975+jpoehnelt@users.noreply.github.com>
@jpoehnelt jpoehnelt merged commit c11d3c4 into main Mar 3, 2026
22 checks passed
@jpoehnelt jpoehnelt deleted the fix-token-storage-tests-11276594267652718308 branch March 3, 2026 23:03
shigechika pushed a commit to shigechika/gws-cli that referenced this pull request Mar 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant