Conversation
jpoehnelt
force-pushed
the
feat/skills-expansion
branch
from
caa05cd to
2ab6bff
Compare
🦋 Changeset detectedLatest commit: da4891c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
- Remove all admin/security/IT recipes (offboard-user, audit-user-login, etc.) - Remove enterprise-only recipes (initiate-litigation-hold) - Replace dangerous recipes (setup-email-forwarding -> create-gmail-filter) - Remove recipes overlapping with gws-workflow-* helpers - Remove thin 2-step recipes better served as helpers - Add 50 curated consumer recipes for Gmail, Drive, Docs, Calendar, Sheets - Update README: link to docs/skills.md, update skill count to 100+ - Fix clippy needless_borrow warnings in generate_skills.rs - Fix lefthook.yml: run fmt/clippy sequentially (parallel causes races)
jpoehnelt
force-pushed
the
feat/skills-expansion
branch
from
2ab6bff to
da4891c
Compare
Contributor
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a substantial expansion of the AI Agent Skills, moving beyond administrative functions to offer a rich set of consumer-focused recipes and predefined personas. It streamlines the skill generation process and enhances discoverability through a new comprehensive skills index, significantly broadening the utility of the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request is a major and impressive overhaul of the skills system, replacing admin-focused recipes with a large set of 50 consumer-focused ones. The introduction of personas and a structured recipe registry is a great improvement. The code changes are extensive, including updates to the skill generation logic in Rust, new YAML definitions, and a large number of new and updated skill markdown files.
My review focuses on a few areas for improvement in the Rust code:
- Updating a deprecated dependency.
- Removing some redundant code in the skill generator.
- Improving the robustness of error handling and URL encoding in the new workflow helpers.
Overall, this is a fantastic contribution that significantly expands the capabilities and user-friendliness of the CLI. The changes are well-structured and the addition of tests for the new registry is much appreciated.
Note: Security Review did not run due to the size of the PR.
Comment on lines
+632
to
+638
| fn urlencoded(s: &str) -> String { | ||
| s.replace('%', "%25") | ||
| .replace(' ', "%20") | ||
| .replace('@', "%40") | ||
| .replace('+', "%2B") | ||
| .replace(':', "%3A") | ||
| } |
Contributor
There was a problem hiding this comment.
This manual implementation of URL encoding is incomplete and might not handle all necessary characters (e.g., &, =, ?), which could lead to malformed URLs and bugs. It's better to use a dedicated library for this. The percent-encoding crate is already available as a transitive dependency and provides a robust solution.
Suggested change
| fn urlencoded(s: &str) -> String { | |
| s.replace('%', "%25") | |
| .replace(' ', "%20") | |
| .replace('@', "%40") | |
| .replace('+', "%2B") | |
| .replace(':', "%3A") | |
| } | |
| fn urlencoded(s: &str) -> String { | |
| use percent_encoding::{utf8_percent_encode, NON_ALPHANUMERIC}; | |
| utf8_percent_encode(s, NON_ALPHANUMERIC).to_string() | |
| } | |
| chrono = "0.4.44" | ||
| keyring = "3.6.3" | ||
| async-trait = "0.1.89" | ||
| serde_yaml = "0.9.34" |
Contributor
There was a problem hiding this comment.
The serde_yaml crate is deprecated and its documentation recommends using serde-yaml (with a hyphen) instead. Please update the dependency to use the recommended crate and avoid potential issues with the deprecated one.
Suggested change
| serde_yaml = "0.9.34" | |
| serde-yaml = "0.9.34" | |
Comment on lines
+167
to
+171
| let about_raw = helper | ||
| .get_about() | ||
| .map(|s| s.to_string()) | ||
| .unwrap_or_default(); | ||
| let about_clean = about_raw.strip_prefix("[Helper] ").unwrap_or(&about_raw); |
Contributor
There was a problem hiding this comment.
This block of code calculates about_clean, which is then unused. The same logic is duplicated inside render_helper_skill. This redundant code should be removed to improve maintainability.
Comment on lines
+287
to
+289
| let events_json = get_json(&client, &events_url, &token) | ||
| .await | ||
| .unwrap_or(json!({})); |
Contributor
There was a problem hiding this comment.
Using unwrap_or here suppresses potential errors from get_json. If the API call fails (e.g., due to network issues or invalid auth), it will be silently ignored, and the function will proceed with empty data. This can make debugging difficult. It would be more robust to propagate the error using the ? operator. The same issue exists for fetching tasks on line 309.
Suggested change
| let events_json = get_json(&client, &events_url, &token) | |
| .await | |
| .unwrap_or(json!({})); | |
| let events_json = get_json(&client, &events_url, &token).await?; | |
|
|
||
| fn epoch_to_rfc3339(epoch: u64) -> String { | ||
| use chrono::{TimeZone, Utc}; | ||
| Utc.timestamp_opt(epoch as i64, 0).unwrap().to_rfc3339() |
Contributor
There was a problem hiding this comment.
The use of .unwrap() on the result of timestamp_opt could cause a panic if the epoch value is out of range for i64. While unlikely with typical u64 inputs, using .expect() with a descriptive message would make any potential panic easier to debug.
Utc.timestamp_opt(epoch as i64, 0).expect("epoch timestamp should be valid").to_rfc3339()
shigechika
pushed a commit
to shigechika/gws-cli
that referenced
this pull request
Mar 20, 2026
* wip * feat: replace admin recipes with 50 consumer-focused recipes - Remove all admin/security/IT recipes (offboard-user, audit-user-login, etc.) - Remove enterprise-only recipes (initiate-litigation-hold) - Replace dangerous recipes (setup-email-forwarding -> create-gmail-filter) - Remove recipes overlapping with gws-workflow-* helpers - Remove thin 2-step recipes better served as helpers - Add 50 curated consumer recipes for Gmail, Drive, Docs, Calendar, Sheets - Update README: link to docs/skills.md, update skill count to 100+ - Fix clippy needless_borrow warnings in generate_skills.rs - Fix lefthook.yml: run fmt/clippy sequentially (parallel causes races) --------- Co-authored-by: jpoehnelt-bot <jpoehnelt-bot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace all admin/enterprise recipes with 50 consumer-focused recipes targeting Gmail, Drive, Docs, Calendar, and Sheets.
What changed
Recipes overhaul
offboard-user,audit-user-login,reset-user-password,suspend-compromised-user, etc.)initiate-litigation-holdusing Vault)setup-email-forwarding) → replaced withcreate-gmail-filtergws-workflow-*helpers (standup-to-chat,weekly-status-update,email-to-task-batch,create-meeting-notes,create-meeting-agenda)append-daily-log,create-keep-note,log-incident, etc.)Recipe categories
label-and-archive-emails,create-gmail-filter,batch-reply-to-emails,forward-labeled-emailsorganize-drive-folder,bulk-download-folder,find-large-files,batch-rename-filesblock-focus-time,reschedule-meeting,find-free-time,batch-invite-to-eventcreate-expense-tracker,copy-sheet-for-new-month,compare-sheet-tabs,generate-report-from-sheetcreate-doc-from-template,draft-email-from-doc,share-doc-and-notifysave-email-attachments,create-events-from-sheet,post-mortem-setup,send-personalized-emailscreate-task-list,review-overdue-tasks,collect-form-responses,create-presentationOther changes
pre-committo runfmtandclippysequentially (parallel causes cargo lock contention)needless_borrowwarningsTesting
cargo test— 260 tests passcargo clippy -- -D warnings— cleancargo fmt -- --check— cleangenerate-skillsproduces 50 recipe skills with no YAML parse warnings