Conversation
🦋 Changeset detectedLatest commit: f91f9e0 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
shigechika
pushed a commit
to shigechika/gws-cli
that referenced
this pull request
Mar 20, 2026
…flatten-and-unicode fix(table): flatten nested objects to dot-notation, safe multi-byte truncation (fixes googleworkspace#40 googleworkspace#43)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #40
Fixes #43
Changes
Nested Object Flattening (issue #40)
flatten_object()helper that recursively converts{"user": {"name": "Alice"}}into[("user.name", "Alice")]format_table_pageandformat_array_as_tablenow use flattened rows, so nested API response objects appear as readable dot-notation columns instead of raw JSON blobsdrive about get) and array tables (drive files list)Multi-byte Truncation Panic Fix (issue #43)
&c[..widths[i]-1]with char-based:c.chars().take(n).collect::<String>()format!("{:width$}")which was also byte-basedTests Added
test_format_table_nested_object_flattened: verifies dot-notation keys, no raw JSON blobstest_format_table_nested_objects_in_array: verifies flattening in array rowstest_format_table_multibyte_truncation_does_not_panic: 70 emojis (4 bytes each) — no panictest_format_table_multibyte_exact_boundary: accented characters do not corrupt output