fix(auth): skip scope picker when gws auth login --services is provided#645
fix(auth): skip scope picker when gws auth login --services is provided#645hy0235 wants to merge 2 commits intogoogleworkspace:mainfrom
gws auth login --services is provided#645Conversation
🦋 Changeset detectedLatest commit: fbb03c6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request optimizes the authentication flow for the CLI by bypassing the interactive scope selection when specific services are requested via the command line. It also enhances the flexibility of service filtering by allowing users to specify exact scope names, ensuring more precise control over requested permissions. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
|
Warning Gemini encountered an error creating the review. You can try again by commenting |
|
CLA has been signed. The remaining checks appear to be waiting for maintainer workflow approval. Thanks! |
Description
Fixes #577.
This change makes
gws auth login --services ...skip the interactive scope picker in default login mode and resolve scopes directly from the provided service filter.It also improves service filtering so exact scope short names such as
documents.readonlyare accepted in addition to prefix-based matches.Dry Run Output: Not applicable for this bug fix.
Checklist:
AGENTS.mdguidelines (no generatedgoogle-*crates).cargo fmt --allto format the code perfectly.cargo clippy -- -D warningsand resolved all warnings.pnpx changeset) to document my changes.