feat: Remove Font Loading from CSS Build - #265
Conversation
🦋 Changeset detectedLatest commit: 2548f48 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Summary of ChangesHello @ZeroChoi2781, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! 이 PR은 CSS 빌드 프로세스에서 Pretendard 폰트의 자동 로딩 기능을 제거하여, 애플리케이션이 폰트 로딩을 직접 관리할 수 있도록 변경합니다. 이는 폰트 로딩 전략에 대한 유연성을 높이고, 잠재적인 중복 로딩을 방지하여 성능을 개선하며, 업계 표준에 맞춰 애플리케이션에 더 많은 제어권을 부여하는 것을 목표로 합니다. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
안녕하세요. PR을 잘 검토했습니다. tsup 설정에서 Pretendard 폰트 자동 로딩 기능을 제거하여 라이브러리 사용자가 폰트 전략을 직접 관리하도록 변경한 점은 유연성 측면에서 좋은 결정입니다. 다만, 이 변경은 사용자에게 영향을 미치는 파괴적인 변경(Breaking Change)이므로, Conventional Commits 명세에 따라 이를 명확히 표시할 필요가 있습니다. 관련하여 packages/core/tsup.config.ts 파일에 구체적인 리뷰 의견을 남겼으니 확인 부탁드립니다.
|
🚫 3 tests failed!
Click here if you need to update snapshots. |
|
NOTE: Since the snapshot is scheduled for update in PR #266, this PR does not handle snapshot failures separately. |
Related Issues
N/A
Description of Changes
Before
@import url("https://cdn.jsdelivr.net/gh/orioncactus/pretendard@v1.3.9/dist/web/variable/pretendardvariable-dynamic-subset.min.css");After
banner.cssoption from tsup config inpackages/core/tsup.config.ts:138-141Rationale
Screenshots
Checklist
Before submitting the PR, please make sure you have checked all of the following items.