Skip to content

feat: Remove Font Loading from CSS Build - #265

Merged
ZeroChoi2781 merged 2 commits into
mainfrom
css-banner
Oct 2, 2025
Merged

feat: Remove Font Loading from CSS Build#265
ZeroChoi2781 merged 2 commits into
mainfrom
css-banner

Conversation

@ZeroChoi2781

Copy link
Copy Markdown
Contributor

Related Issues

N/A

Description of Changes

Before

  • CSS build included automatic Pretendard font loading via tsup banner configuration
  • Font was automatically imported in generated CSS files: @import url("https://cdn.jsdelivr.net/gh/orioncactus/pretendard@v1.3.9/dist/web/variable/pretendardvariable-dynamic-subset.min.css");

After

  • Removed banner.css option from tsup config in packages/core/tsup.config.ts:138-141
  • Font loading is now the responsibility of the consuming application
  • Applications must manually include Pretendard or their preferred font

Rationale

  1. Flexibility: Applications can choose their preferred font loading strategy (CDN, self-hosted, variable fonts, etc.)
  2. Performance: Avoids duplicate font loading when applications already have font management
  3. Industry Standard: Aligns with how other major design systems handle typography
  4. Control: Gives applications full control over font loading timing and fallbacks

Screenshots

Checklist

Before submitting the PR, please make sure you have checked all of the following items.

  • The PR title follows the Conventional Commits convention. (e.g., feat, fix, docs, style, refactor, test, chore)
  • I have added tests for my changes.
  • I have updated the Storybook or relevant documentation.
  • I have added a changeset for this change. (e.g., for any changes that affect users, such as component prop changes or new features).
  • I have performed a self-code review.
  • I have followed the project's coding conventions and component patterns.

@changeset-bot

changeset-bot Bot commented Sep 29, 2025

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 2548f48

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@vapor-ui/core Patch
figma-plugin Patch
website Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercel Bot commented Sep 29, 2025

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
vapor-ui Ready Ready Preview Comment Sep 29, 2025 9:13am

@ZeroChoi2781 ZeroChoi2781 changed the title feat: css 빌드에서 font load 제거 feat: Remove Font Loading from CSS Build Sep 29, 2025
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @ZeroChoi2781, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

이 PR은 CSS 빌드 프로세스에서 Pretendard 폰트의 자동 로딩 기능을 제거하여, 애플리케이션이 폰트 로딩을 직접 관리할 수 있도록 변경합니다. 이는 폰트 로딩 전략에 대한 유연성을 높이고, 잠재적인 중복 로딩을 방지하여 성능을 개선하며, 업계 표준에 맞춰 애플리케이션에 더 많은 제어권을 부여하는 것을 목표로 합니다.

Highlights

  • CSS 빌드에서 폰트 로딩 제거: tsup 빌드 설정에서 Pretendard 폰트의 자동 로딩을 제거했습니다. 이제 폰트 로딩은 애플리케이션의 책임이 됩니다.
  • 폰트 로딩 유연성 증가: 애플리케이션이 자체적으로 폰트 로딩 전략을 선택할 수 있도록 하여 유연성을 높였습니다.
  • 성능 및 제어 개선: 중복 폰트 로딩을 방지하고, 폰트 로딩 타이밍 및 폴백에 대한 완전한 제어를 제공하여 성능을 향상시킵니다.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@ZeroChoi2781 ZeroChoi2781 self-assigned this Sep 29, 2025
@ZeroChoi2781 ZeroChoi2781 added scope: all Issues related to the all scope of component. type: style labels Sep 29, 2025

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

안녕하세요. PR을 잘 검토했습니다. tsup 설정에서 Pretendard 폰트 자동 로딩 기능을 제거하여 라이브러리 사용자가 폰트 전략을 직접 관리하도록 변경한 점은 유연성 측면에서 좋은 결정입니다. 다만, 이 변경은 사용자에게 영향을 미치는 파괴적인 변경(Breaking Change)이므로, Conventional Commits 명세에 따라 이를 명확히 표시할 필요가 있습니다. 관련하여 packages/core/tsup.config.ts 파일에 구체적인 리뷰 의견을 남겼으니 확인 부탁드립니다.

@vapor-ui

vapor-ui commented Sep 29, 2025

Copy link
Copy Markdown
Collaborator

🚫 3 tests failed!

Tests Passed Failed Duration Report
120 117 3 3m 28s Open report ↗︎

Click here if you need to update snapshots.

@ZeroChoi2781

Copy link
Copy Markdown
Contributor Author

NOTE: Since the snapshot is scheduled for update in PR #266, this PR does not handle snapshot failures separately.

@ZeroChoi2781
ZeroChoi2781 merged commit f0f643b into main Oct 2, 2025
9 of 10 checks passed
@ZeroChoi2781
ZeroChoi2781 deleted the css-banner branch October 2, 2025 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope: all Issues related to the all scope of component. type: style

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants