Skip to content

chore(renovate): separate patch and minor updates for other dependencies #432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MaxLee-dev wants to merge 3 commits into
base: main
Choose a base branch
from
Open

chore(renovate): separate patch and minor updates for other dependencies #432

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b6ccb30
chore(renovate): separate patch and minor updates for other dependencies
MaxLee-dev Jan 8, 2026
e4940cc
Merge branch 'main' of https://github.com/goorm-dev/vapor-ui into sep…
MaxLee-dev Feb 3, 2026
8886564
fix: update renovate configuration for clarity and consistency
MaxLee-dev Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 27 additions & 10 deletions .github/renovate.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,18 +57,35 @@
"matchPackageNames": ["/^@base-ui-components\\/.*/"]
},
{
"description": "All other dependencies grouped together",
"groupName": "Other Dependencies",
"description": "Group patch updates for other dependencies",
"groupName": "Other Dependencies (patch)",
"matchUpdateTypes": ["patch"],
"automerge": true,
"labels": ["type: dependencies"],
"matchPackageNames": ["*"],
"excludePackageNames": [
"react",
"react-dom",
"@types/react",
"@types/react-dom",
"/^@vanilla-extract\\/.*/",
"/^@base-ui-components\\/.*/"
]
},
{
"description": "Group minor updates for other dependencies",
"groupName": "Other Dependencies (minor)",
"matchUpdateTypes": ["minor"],
"automerge": false,
"matchPackageNames": [
"*",
"!react",
"!react-dom",
"!@types/react",
"!@types/react-dom",
"!/^@vanilla-extract\\/.*/",
"!/^@base-ui-components\\/.*/"
"labels": ["type: dependencies"],
"matchPackageNames": ["*"],
"excludePackageNames": [
"react",
"react-dom",
"@types/react",
"@types/react-dom",
"/^@vanilla-extract\\/.*/",
"/^@base-ui-components\\/.*/"
]
}
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Jan 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

excludePackageNames 목록이 "Other Dependencies (patch)"와 "Other Dependencies (minor)" 두 그룹에 동일하게 중복되어 있습니다.

이는 향후 유지보수 시 잠재적인 오류를 유발할 수 있습니다. 예를 들어, 새로운 패키지 그룹(예: lodash)을 추가하고 제외 목록을 갱신할 때, 두 곳 모두를 수정해야 합니다. 만약 한 곳이라도 누락되면 해당 패키지 업데이트가 의도치 않게 "Other Dependencies" 그룹에 포함될 수 있습니다.

Renovate의 JSON 설정 방식상 이 중복을 간단히 제거하기는 어렵지만, 이 구조를 인지하고 향후 제외 목록 변경 시 두 그룹을 항상 함께 수정하도록 주의가 필요합니다.

References
  1. 코드 리뷰 답변은 한국어로 제공해야 합니다. (link)

]
Expand Down
Loading