-
Notifications
You must be signed in to change notification settings - Fork 10
docs: add component anatomy explorer for all compound components #472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
MaxLee-dev
wants to merge
1
commit into
docs-component-analyzer
Choose a base branch
from
add-component-anatomy
base: docs-component-analyzer
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+793
−0
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 changes: 18 additions & 0 deletions
18
apps/website/src/components/demo/examples/avatar/anatomy-avatar.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| import { Avatar, Flex } from '@vapor-ui/core'; | ||
|
|
||
| import { VAPOR_LOGO_URL } from '~/constants/image-urls'; | ||
|
|
||
| export default function AnatomyAvatar() { | ||
| return ( | ||
| <Flex gap="$200"> | ||
| <Avatar.Root data-part="Root" alt="Vapor" src={VAPOR_LOGO_URL}> | ||
| <Avatar.ImagePrimitive data-part="ImagePrimitive" /> | ||
| <Avatar.FallbackPrimitive data-part="FallbackPrimitive">V</Avatar.FallbackPrimitive> | ||
| </Avatar.Root> | ||
| <Avatar.Root data-part="Root"> | ||
| <Avatar.ImagePrimitive data-part="ImagePrimitive" /> | ||
| <Avatar.FallbackPrimitive data-part="FallbackPrimitive">V</Avatar.FallbackPrimitive> | ||
| </Avatar.Root> | ||
| </Flex> | ||
| ); | ||
| } |
27 changes: 27 additions & 0 deletions
27
apps/website/src/components/demo/examples/breadcrumb/anatomy-breadcrumb.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| import { Breadcrumb } from '@vapor-ui/core'; | ||
|
|
||
| export default function AnatomyBreadcrumb() { | ||
| return ( | ||
| <Breadcrumb.RootPrimitive data-part="RootPrimitive"> | ||
| <Breadcrumb.ListPrimitive data-part="ListPrimitive"> | ||
| <Breadcrumb.ItemPrimitive data-part="ItemPrimitive"> | ||
| <Breadcrumb.LinkPrimitive data-part="LinkPrimitive" href="#"> | ||
| Home | ||
| </Breadcrumb.LinkPrimitive> | ||
| </Breadcrumb.ItemPrimitive> | ||
| <Breadcrumb.Separator data-part="Separator" /> | ||
| <Breadcrumb.ItemPrimitive> | ||
| <Breadcrumb.LinkPrimitive href="#">Products</Breadcrumb.LinkPrimitive> | ||
| </Breadcrumb.ItemPrimitive> | ||
| <Breadcrumb.Separator /> | ||
| <Breadcrumb.Ellipsis data-part="Ellipsis" /> | ||
| <Breadcrumb.Separator /> | ||
| <Breadcrumb.ItemPrimitive> | ||
| <Breadcrumb.LinkPrimitive href="#" current> | ||
| Details | ||
| </Breadcrumb.LinkPrimitive> | ||
| </Breadcrumb.ItemPrimitive> | ||
| </Breadcrumb.ListPrimitive> | ||
| </Breadcrumb.RootPrimitive> | ||
| ); | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anatomy Explorer가 모든 파트를 하이라이트할 수 있도록data-part속성이 누락된 컴포넌트들에 추가하는 것이 좋습니다.breadcrumb.json에 정의된 모든 파트가 예제 코드에 포함되어야 합니다. 예를 들어, 일부ItemPrimitive,LinkPrimitive및Separator에data-part속성이 누락되었습니다.