feat(Skeleton): Add Skeleton component#481
Conversation
🦋 Changeset detectedLatest commit: 165926e The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Summary of ChangesHello @MaxLee-dev, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
새로운 Skeleton 컴포넌트 추가에 대한 PR입니다. 전반적으로 잘 작성되었지만, 프로젝트 스타일 가이드와 관련하여 두 가지 개선점을 제안합니다. 첫째, 컴포넌트의 엔트리포인트(index.ts) 파일이 스타일 가이드의 네임스페이스 export 규칙을 따르도록 수정해야 합니다. 둘째, skeleton.tsx 파일에서 Props 타입을 namespace 대신 직접 interface로 export하여 가독성과 일관성을 높이는 것을 제안합니다.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
✅ All tests passed!
Click here if you need to update snapshots. |
Description of Changes
Add a new
Skeletoncomponent that provides visual placeholder feedback while content is loading.Animation System
The Skeleton component supports three animation variants:
1. Shimmer (Default)
A light sweep effect that moves from left to right, creating a "shine" appearance:
linear-gradientwith three color stops (gray-100→gray-050→gray-100)6.25remthat travels across the elementbackground-positionanimates fromleft -6.25remtoright -6.25rem1switheasetiming function2. Pulse
A fading effect where the entire element blinks:
1→0.5→11.2swithease-in-outtiming function3. None
Disables all animations for static placeholder display.
Accessibility
prefers-reduced-motion: reducemedia query by automatically disabling animationsroleoraria-*attributes added (pure visual placeholder, avoids screen reader noise)Variants
shaperounded,squareroundedsizesm,md,lg,xlmdanimationshimmer,pulse,noneshimmerChecklist