chore(icons): regenerate icon components with SVGR + svgo output - #722
Merged
Conversation
🦋 Changeset detectedLatest commit: 4e599bd The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedToo many files! This PR contains 816 files, which is 716 over the limit of 100. To get a review, reduce the PR to 100 files or fewer by splitting it into smaller PRs or changing its base branch. Upgrade to a paid plan to raise the limit. Usage-priced reviews support at most 300 files. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (816)
You can disable this status message by setting the |
MaxLee-dev
force-pushed
the
chore/regenerate-icons-svgr
branch
from
September 3, 2026 00:59
14b9243 to
4e599bd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@coderabbitai summary
변경 내역
@vapor-ui/icons의 아이콘 컴포넌트 816개를 새 변환 파이프라인(SVGR + svgo)으로 다시 생성했습니다. #715 에서 변환기만 바꿨고, 이 PR은 그 변환기를 실제로 돌린 결과물입니다.diff가 많은 이유
기존에는 정규식 문자열 파싱으로 SVG를 JSX로 바꿨고, 이제는 svgo로 최적화한 뒤 SVGR로 컴포넌트를 만듭니다. 그래서 파일 대부분이 통째로 바뀝니다.
xmlns→fill→viewBox)fill="none"이 붙어 stroke가 채워지지 않음fill="currentColor"가 path에 명시됨렌더링은 그대로인가
별도 워크트리에서 Figma 원본 SVG와 코드 렌더 결과를 픽셀 단위로 대조했고, 814개 전부 통과했습니다(최대 차이 0.0866%, symbol 258개는 0.0000%). 검사기 자체는 후속 PR로 올립니다.