Skip to content
Open
Show file tree
Hide file tree
Changes from 83 commits
Commits
Show all changes
89 commits
Select commit Hold shift + click to select a range
0896d48
install rolldown & remove rollup-related dependencies
noahchoii Jul 9, 2026
00de410
migrate from rollup to rolldown
noahchoii Jul 9, 2026
d918c3e
remove get-tsconfig
noahchoii Jul 9, 2026
8b247e4
format
noahchoii Jul 9, 2026
5b361ae
remove build:rollup
noahchoii Jul 9, 2026
f60ff1d
split tsconfig according to scope
noahchoii Jul 16, 2026
0047235
edit ts-api-extractor integrations
noahchoii Jul 16, 2026
8e7efeb
Merge branch 'main' into rolldown
noahchoii Jul 16, 2026
a95fb75
Merge branch 'main' into rolldown
noahchoii Jul 27, 2026
7729185
cleanup tsconfig
noahchoii Jul 29, 2026
c674ee3
unify tsconfig
noahchoii Jul 29, 2026
94af759
disallow js in tsconfig, unify include with "."
noahchoii Jul 30, 2026
dc119dd
add .storybook
noahchoii Jul 30, 2026
d5f29ef
add hooks tsconfig exclude
noahchoii Jul 30, 2026
c53fe07
edit core tsconfig path from ts-api-extractor
noahchoii Jul 30, 2026
ee1b78a
edit ts-api-extractor constants
noahchoii Jul 30, 2026
9c85d19
add test case for default paths
noahchoii Jul 30, 2026
525240f
remove path test
noahchoii Jul 30, 2026
1258eb9
edit execution of ts-api-extractor test command
noahchoii Jul 30, 2026
fec56fc
add `@vapor-ui/composites` package
noahchoii Aug 5, 2026
48d53d5
split rolldown-config
noahchoii Aug 7, 2026
7a7e618
adjust rolldown configs to core/composites
noahchoii Aug 7, 2026
a716b09
add new `Dialog` composites
noahchoii Aug 13, 2026
94844fd
resolve storybook alias
noahchoii Aug 13, 2026
a309585
edit dialog style
noahchoii Aug 14, 2026
9a8e0e5
propagate slots props
noahchoii Aug 18, 2026
f29bcf7
add size prop & export with ts namespace
noahchoii Aug 18, 2026
193e20f
adjust rsc
noahchoii Aug 18, 2026
8bbc9b1
Merge branch 'main' into new-composites-package
noahchoii Aug 19, 2026
bc16436
fix: build dts for esm, cjs
noahchoii Aug 19, 2026
36d8651
add convention docs
noahchoii Aug 19, 2026
22edd97
adjust conventions.md for claude.md
noahchoii Aug 19, 2026
3c8edf7
add changeset
noahchoii Aug 19, 2026
83e4a76
adjust rolldown-config for core package
noahchoii Aug 19, 2026
91c48c3
format
noahchoii Aug 19, 2026
8776117
edit composites regressions port number
noahchoii Aug 19, 2026
4bef67b
update snapshots
noahchoii Aug 19, 2026
04e9e77
correct rolldown output type
noahchoii Aug 19, 2026
1989a30
notice resolve alias to bundler
noahchoii Aug 19, 2026
af65f87
replace visual into variants
noahchoii Aug 19, 2026
55fb0a4
add eslint & exec lint
noahchoii Aug 19, 2026
a89a31b
escape dot when find vapor.xxx layer
noahchoii Aug 19, 2026
e0ad52a
lint & format
noahchoii Aug 19, 2026
5cf01fc
remove footer & export assistive, action prop
noahchoii Aug 20, 2026
73079bf
infer slots prop types
noahchoii Aug 20, 2026
202d52b
ajdust design feedback
noahchoii Aug 20, 2026
2589af6
replace padding into margin
noahchoii Aug 21, 2026
0d1dbbe
early return when not exist render
noahchoii Aug 21, 2026
7172c1b
Merge branch 'main' into new-composites-package
noahchoii Aug 21, 2026
da37aa6
code-review
noahchoii Aug 24, 2026
0be04f5
code-review
noahchoii Aug 24, 2026
6843654
refactor dialog interface
noahchoii Aug 24, 2026
42b39e1
replace CONVENTIONS.md into rules
noahchoii Aug 24, 2026
3d04478
refactor action & assistive interface
noahchoii Aug 25, 2026
6f0d3f4
Merge branch 'main' into new-composites-package
noahchoii Aug 25, 2026
0840709
add manual close example to dialog stories
noahchoii Aug 25, 2026
65c2c28
apply Dialog Root naming to JSDoc
noahchoii Aug 25, 2026
0adef44
remove render prop example on actions
noahchoii Aug 25, 2026
23a7dcf
enhance create-slots early return conditions
noahchoii Aug 25, 2026
c9b7803
omit variants props from Action, Assistive
noahchoii Aug 25, 2026
008b144
Merge branch 'main' into new-composites-package
noahchoii Aug 25, 2026
74a8557
remove not found plugin
noahchoii Aug 25, 2026
bec0c26
add alert-dialog
noahchoii Aug 26, 2026
68aed96
edit alert-dialog description style
noahchoii Aug 26, 2026
f93b17d
update snapshots
noahchoii Aug 26, 2026
cb40e98
edit alert-dialog widths
noahchoii Aug 26, 2026
a0f966e
add changeset
noahchoii Aug 26, 2026
e5a82c7
add composites alert-dialog
noahchoii Aug 26, 2026
ba70f9f
add changeset
noahchoii Aug 26, 2026
8f31bfa
edit dialog type values
noahchoii Aug 27, 2026
80594d1
change some props to required
noahchoii Aug 28, 2026
231da20
change info type prop name to confirm
noahchoii Sep 1, 2026
1a2b044
apply alert-dialog style change
noahchoii Sep 1, 2026
c77214a
Merge branch 'main' into feature/vapor-258
noahchoii Sep 3, 2026
aa73303
update snapshots
noahchoii Sep 3, 2026
6cccd96
add alert-dialog header
noahchoii Sep 3, 2026
601cbce
apply core alert-dialog changes to composites
noahchoii Sep 3, 2026
4103db2
export alert-dialog
noahchoii Sep 3, 2026
6689099
update snapshots
noahchoii Sep 3, 2026
08301f0
add sha in regressions reports comment
noahchoii Sep 3, 2026
9c99818
allow number 0 for children
noahchoii Sep 3, 2026
58b75e3
edit alert-dialog header comments
noahchoii Sep 3, 2026
dd11e22
add alert-dialog code-connect
noahchoii Sep 3, 2026
88722c4
edit SHA_FULL to github.sha
noahchoii Sep 4, 2026
54265e4
Merge branch 'main' into feature/vapor-258
noahchoii Sep 4, 2026
9fcd46a
update changeset
noahchoii Sep 4, 2026
840c429
edit semantic naming
noahchoii Sep 4, 2026
61f47db
format
noahchoii Sep 4, 2026
0ee313b
Merge branch 'main' into feature/vapor-258
noahchoii Sep 4, 2026
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/open-poems-return.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

core component alert dialog header component part가 추가된 것 같습니다.! 이 부분도 추가하면 어떨까요? 그리고 composite도 alert component가 추가되었으니 minor로 가면 어떨까요?

파일을 그럼 분리해서 두 개 추가해야 할 듯 합니다.!

'@vapor-ui/composites': patch
---

add composite `AlertDialog` component
12 changes: 9 additions & 3 deletions .github/workflows/test-regressions.yml
Original file line number Diff line number Diff line change
Expand Up @@ -158,19 +158,25 @@ jobs:
DURATION="Unknown"
fi

# Resolve commit SHA (PR head on pull_request, otherwise github.sha)
SHA_FULL="${{ github.event.pull_request.head.sha || github.sha }}"
Comment thread
coderabbitai[bot] marked this conversation as resolved.
Outdated
SHA_SHORT="${SHA_FULL:0:7}"

echo "passed=$PASSED" >> $GITHUB_OUTPUT
echo "failed=$FAILED" >> $GITHUB_OUTPUT
echo "total=$TOTAL" >> $GITHUB_OUTPUT
echo "duration=$DURATION" >> $GITHUB_OUTPUT
echo "sha_full=$SHA_FULL" >> $GITHUB_OUTPUT
echo "sha_short=$SHA_SHORT" >> $GITHUB_OUTPUT

- uses: marocchino/sticky-pull-request-comment@v2
with:
message: |
${{ contains(needs.test.result, 'failure') && format('🚫 **{0} tests failed!**', steps.parse-results.outputs.failed) || '✅ **All tests passed!**' }}

| Tests | Passed | Failed | Duration | Report |
| :---- | :----- | :----- | :------- | :----- |
| ${{ steps.parse-results.outputs.total }} | ${{ steps.parse-results.outputs.passed }} | ${{ steps.parse-results.outputs.failed }} | ${{ steps.parse-results.outputs.duration }} | [Open report ↗︎](http://${{ env.BUCKET_NAME }}/${{ env.REPORT_PATH }}/index.html) |
| Tests | Passed | Failed | Duration | Commit | Report |
| :---- | :----- | :----- | :------- | :----- | :----- |
| ${{ steps.parse-results.outputs.total }} | ${{ steps.parse-results.outputs.passed }} | ${{ steps.parse-results.outputs.failed }} | ${{ steps.parse-results.outputs.duration }} | [`${{ steps.parse-results.outputs.sha_short }}`](https://github.com/${{ github.repository }}/commit/${{ steps.parse-results.outputs.sha_full }}) | [Open report ↗︎](http://${{ env.BUCKET_NAME }}/${{ env.REPORT_PATH }}/index.html) |

[Click here](https://github.com/goorm-dev/vapor-ui/actions/workflows/update-snapshots.yml) if you need to update snapshots.

Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
// url=https://www.figma.com/design/he4tiAGOKGPl0Fm56ZpJsy/-Composites--Vapor-Design-System?node-id=2359-50676&t=TnnpGTYHBh9MjPQH-11
// source=src/components/alert-dialog/alert-dialog.tsx
// component=AlertDialog
import figma from 'figma';

import { getProperties } from '../../utils/figma-utils';

const instance = figma.selectedInstance;

const popup = getProperties(instance, '(Popup)', {
type: { kind: 'enum', name: 'type', options: { critical: 'critical', confirm: 'confirm' } },
});

const header = getProperties(instance, '(Header)', {
description: { kind: 'string', name: 'description' },
title: { kind: 'string', name: 'title' },
});

const body = getProperties(instance, '(Body)', {
children: { kind: 'slot', name: '(content)' },
});

const footer = getProperties(instance, '(Footer)', {
cancel: { kind: 'instance', name: 'Cancel' },
action: { kind: 'instance', name: 'Action' },
});

export default {
example: figma.code`
<AlertDialog.Root
${popup.type}
${header.description}
${header.title}
${footer.cancel}
${footer.action}
Comment thread
noahchoii marked this conversation as resolved.
>
${body.children}
</AlertDialog.Root>
`,
imports: ['import { AlertDialog } from "@vapor-ui/composites"'],
id: 'alert-dialog',
metadata: { nestable: false },
};
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
import type { Meta, StoryObj } from '@storybook/react-vite';
import { Button } from '@vapor-ui/core';

import { AlertDialog } from '.';

export default {
title: 'Composites/AlertDialog',
component: AlertDialog.Root,
argTypes: {
type: { control: 'inline-radio', options: ['critical', 'confirm'] },
title: { control: 'text' },
description: { control: 'text' },
},
} satisfies Meta<typeof AlertDialog.Root>;

type Story = StoryObj<typeof AlertDialog.Root>;

export const Default: Story = {
args: {
type: 'critical',
title: '이 항목을 삭제할까요?',
description: '삭제하면 되돌릴 수 없습니다. 연결된 기록도 함께 사라집니다.',
},
render: ({
action = <AlertDialog.Action>Remove</AlertDialog.Action>,
cancel = <AlertDialog.Cancel>Cancel</AlertDialog.Cancel>,
...args
}) => {
return (
<AlertDialog.Root
trigger={<Button>트리거</Button>}
cancel={cancel}
action={action}
{...args}
/>
);
},
};
Loading
Loading