Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spatial layout #1101

Draft
wants to merge 30 commits into
base: higlassless
Choose a base branch
from
Draft

Spatial layout #1101

wants to merge 30 commits into from

Conversation

dvdkouril
Copy link
Collaborator

Opening this extremely preliminary PR to track features to implement during the integration of 3D genomic data into Gosling.

Features

  • MVP for a view with 'spatial' layout type: model sources from data field, ability to specify color, scale fields
  • linking to other Gosling views
    • using color and/or scale channels to encode non-3D data
    • brushing and linking

dvdkouril and others added 11 commits January 29, 2025 15:35
I think this is changing due to me using newer pnpm?
just a test of adjusting some property from the grammar and reflecting that in chromospace view
etowah's prototype made a new track that was detected by looking for type = '3D'
* fix(core): typescript errors when building (#1102)

* fix: address all typescript errors

* last error

* format, fix tests more, fix build

* fix: uncaught error on axis track

* chore: merge recent changes
@sehilyi

This comment was marked as resolved.

sehilyi and others added 10 commits February 12, 2025 15:05
* refactor(core): remove unused code related to HiGlass (#1105)

* working on removing unused higlass code

* further remove

* remove console log

* remove higlass specs from the editor

* fix test

* rename a file and a function that are no longer related to HiGlass

* fix(core): remove build errors (#1109)

* fix: address build errors

* fix lint errors
figuring out all the places that need to be touched and how the flow of spec options is done.
super brittle implementation so far, but illustrates fetching data from the CSV data fetcher, transforming to arrow, and sending to chromospace for rendering
also: function to find min and max for the particular column used to specify `size` and `color` values
implemented a fix for behavior that i need
doesn't work right now; will use as a playground for implementing the desired behavior
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants